[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] tcg/arm: Use tcg_out_mov_reg rat
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] tcg/arm: Use tcg_out_mov_reg rather than inline equivalent code |
Date: |
Thu, 27 Sep 2012 21:57:43 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Sep 27, 2012 at 02:55:43PM +0100, Peter Maydell wrote:
> Use the recently introduced tcg_out_mov_reg() function rather than
> the equivalent inline code.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> This is a minor follow-on cleanup patch after commit 9716ef3b1.
>
> tcg/arm/tcg-target.c | 15 +++------------
> 1 file changed, 3 insertions(+), 12 deletions(-)
>
> diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c
> index 2bad0a2..5e8dbdd 100644
> --- a/tcg/arm/tcg-target.c
> +++ b/tcg/arm/tcg-target.c
> @@ -1197,20 +1197,11 @@ static inline void tcg_out_qemu_ld(TCGContext *s,
> const TCGArg *args, int opc)
> case 1:
> case 2:
> default:
> - if (data_reg != TCG_REG_R0) {
> - tcg_out_dat_reg(s, COND_AL, ARITH_MOV,
> - data_reg, 0, TCG_REG_R0, SHIFT_IMM_LSL(0));
> - }
> + tcg_out_mov_reg(s, COND_AL, data_reg, TCG_REG_R0);
> break;
> case 3:
> - if (data_reg != TCG_REG_R0) {
> - tcg_out_dat_reg(s, COND_AL, ARITH_MOV,
> - data_reg, 0, TCG_REG_R0, SHIFT_IMM_LSL(0));
> - }
> - if (data_reg2 != TCG_REG_R1) {
> - tcg_out_dat_reg(s, COND_AL, ARITH_MOV,
> - data_reg2, 0, TCG_REG_R1, SHIFT_IMM_LSL(0));
> - }
> + tcg_out_mov_reg(s, COND_AL, data_reg, TCG_REG_R0);
> + tcg_out_mov_reg(s, COND_AL, data_reg2, TCG_REG_R1);
> break;
> }
Reviewed-by: Aurelien Jarno <address@hidden>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net