[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] pflash_cfi02.c: associate "cfi.pflash02" to "
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-trivial] [PATCH] pflash_cfi02.c: associate "cfi.pflash02" to "Storage devices" category |
Date: |
Wed, 10 Dec 2014 10:52:52 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 10/12/2014 10:11, Michael Tokarev wrote:
> 07.12.2014 21:20, Antony Pavlov wrote:
>> Signed-off-by: Antony Pavlov <address@hidden>
>> ---
>> hw/block/pflash_cfi02.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c
>> index 8513a17..389b4aa 100644
>> --- a/hw/block/pflash_cfi02.c
>> +++ b/hw/block/pflash_cfi02.c
>> @@ -744,6 +744,7 @@ static void pflash_cfi02_class_init(ObjectClass *klass,
>> void *data)
>>
>> dc->realize = pflash_cfi02_realize;
>> dc->props = pflash_cfi02_properties;
>> + set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
>> }
>>
>> static const TypeInfo pflash_cfi02_info = {
>
> Hm. While the patch itself is trivial, and it _seems_ it
> fixes a bug, I'm not sure of possible effects of this.
>
> What prob it has now, does this device work? If yes,
> why it needs fixing? Do we care about compatibility
> with previous versions, about migration?
This affects nothing but help messages.
Paolo