[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH 07/16] xen: Use DIV_ROUND_UP
From: |
Stefano Stabellini |
Subject: |
Re: [Qemu-trivial] [PATCH 07/16] xen: Use DIV_ROUND_UP |
Date: |
Wed, 1 Jun 2016 10:33:33 +0100 (BST) |
User-agent: |
Alpine 2.10 (DEB 1266 2009-07-14) |
On Tue, 31 May 2016, Laurent Vivier wrote:
> Replace (((n) + (d) - 1) /(d)) by DIV_ROUND_UP(n,d).
>
> This patch is the result of coccinelle script
> scripts/coccinelle/round.cocci
>
> CC: Stefano Stabellini <address@hidden>
> Signed-off-by: Laurent Vivier <address@hidden>
Reviewed-by: Stefano Stabellini <address@hidden>
> hw/display/xenfb.c | 4 ++--
> xen-hvm.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c
> index 9866dfd..570b097 100644
> --- a/hw/display/xenfb.c
> +++ b/hw/display/xenfb.c
> @@ -472,9 +472,9 @@ static int xenfb_map_fb(struct XenFB *xenfb)
> xenfb->pixels = NULL;
> }
>
> - xenfb->fbpages = (xenfb->fb_len + (XC_PAGE_SIZE - 1)) / XC_PAGE_SIZE;
> + xenfb->fbpages = DIV_ROUND_UP(xenfb->fb_len, XC_PAGE_SIZE);
> n_fbdirs = xenfb->fbpages * mode / 8;
> - n_fbdirs = (n_fbdirs + (XC_PAGE_SIZE - 1)) / XC_PAGE_SIZE;
> + n_fbdirs = DIV_ROUND_UP(n_fbdirs, XC_PAGE_SIZE);
>
> pgmfns = g_malloc0(sizeof(xen_pfn_t) * n_fbdirs);
> fbmfns = g_malloc0(sizeof(xen_pfn_t) * xenfb->fbpages);
> diff --git a/xen-hvm.c b/xen-hvm.c
> index 01ee25d..a0da8d7 100644
> --- a/xen-hvm.c
> +++ b/xen-hvm.c
> @@ -567,7 +567,7 @@ static void xen_sync_dirty_bitmap(XenIOState *state,
> {
> hwaddr npages = size >> TARGET_PAGE_BITS;
> const int width = sizeof(unsigned long) * 8;
> - unsigned long bitmap[(npages + width - 1) / width];
> + unsigned long bitmap[DIV_ROUND_UP(npages, width)];
> int rc, i, j;
> const XenPhysmap *physmap = NULL;
>
> --
> 2.5.5
>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-trivial] [PATCH 07/16] xen: Use DIV_ROUND_UP,
Stefano Stabellini <=