[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PULL 12/52] replace muldiv64(a, b, c) by (uint64_t)a * b
From: |
Michael Tokarev |
Subject: |
[Qemu-trivial] [PULL 12/52] replace muldiv64(a, b, c) by (uint64_t)a * b / c |
Date: |
Sun, 5 Jun 2016 10:42:49 +0300 |
From: Laurent Vivier <address@hidden>
When "a" and "b" are 32bit values, we don't have to cast
them to 128bit, 64bit is enough.
This patch is the result of coccinelle script
scripts/coccinelle/simplify_muldiv64.cocci
Signed-off-by: Laurent Vivier <address@hidden>
For xtensa PIC:
Acked-by: Max Filippov <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
hw/audio/gus.c | 2 +-
hw/xtensa/pic_cpu.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/audio/gus.c b/hw/audio/gus.c
index 9dd6947..6c02646 100644
--- a/hw/audio/gus.c
+++ b/hw/audio/gus.c
@@ -144,7 +144,7 @@ static void GUS_callback (void *opaque, int free)
s->left = samples;
reset:
- gus_irqgen (&s->emu, muldiv64 (net, 1000000, s->freq));
+ gus_irqgen (&s->emu, (uint64_t)net * 1000000 / s->freq);
}
int GUS_irqrequest (GUSEmuState *emu, int hwirq, int n)
diff --git a/hw/xtensa/pic_cpu.c b/hw/xtensa/pic_cpu.c
index ccf65fd..2bed64f 100644
--- a/hw/xtensa/pic_cpu.c
+++ b/hw/xtensa/pic_cpu.c
@@ -122,8 +122,8 @@ void xtensa_rearm_ccompare_timer(CPUXtensaState *env)
}
env->wake_ccount = wake_ccount;
timer_mod(env->ccompare_timer, env->halt_clock +
- muldiv64(wake_ccount - env->sregs[CCOUNT],
- 1000000, env->config->clock_freq_khz));
+ (uint64_t)(wake_ccount - env->sregs[CCOUNT]) *
+ 1000000 / env->config->clock_freq_khz);
}
static void xtensa_ccompare_cb(void *opaque)
--
2.1.4
- Re: [Qemu-trivial] [PULL 50/52] pc-bios/s390-ccw: Use DIV_ROUND_UP, (continued)
- [Qemu-trivial] [PULL 29/52] tests: Remove unnecessary glib.h includes, Michael Tokarev, 2016/06/05
- [Qemu-trivial] [PULL 52/52] hbitmap: Use DIV_ROUND_UP, Michael Tokarev, 2016/06/05
- [Qemu-trivial] [PULL 13/52] ppc: Remove a potential overflow in muldiv64(), Michael Tokarev, 2016/06/05
- [Qemu-trivial] [PULL 43/52] xen: Use DIV_ROUND_UP, Michael Tokarev, 2016/06/05
- [Qemu-trivial] [PULL 30/52] qga: Remove unnecessary glib.h includes, Michael Tokarev, 2016/06/05
- [Qemu-trivial] [PULL 23/52] hw: Clean up includes, Michael Tokarev, 2016/06/05
- [Qemu-trivial] [PULL 04/52] qga: spelling fix, Michael Tokarev, 2016/06/05
- [Qemu-trivial] [PULL 35/52] thunk: Drop unused NO_THUNK_TYPE_SIZE guards, Michael Tokarev, 2016/06/05
- [Qemu-trivial] [PULL 51/52] qemu-timer: Use DIV_ROUND_UP, Michael Tokarev, 2016/06/05
- [Qemu-trivial] [PULL 12/52] replace muldiv64(a, b, c) by (uint64_t)a * b / c,
Michael Tokarev <=
- [Qemu-trivial] [PULL 21/52] fw_cfg: follow CODING_STYLE, Michael Tokarev, 2016/06/05
- [Qemu-trivial] [PULL 02/52] hw/ipmi: fix spelling, Michael Tokarev, 2016/06/05
- [Qemu-trivial] [PULL 16/52] configure: Use $(..) instead of deprecated `..`, Michael Tokarev, 2016/06/05
- [Qemu-trivial] [PULL 41/52] block: Use DIV_ROUND_UP, Michael Tokarev, 2016/06/05
- [Qemu-trivial] [PULL 22/52] replay: Clean up includes, Michael Tokarev, 2016/06/05
- [Qemu-trivial] [PULL 45/52] SPICE: Use DIV_ROUND_UP, Michael Tokarev, 2016/06/05
- [Qemu-trivial] [PULL 39/52] qcow/qcow2: Use DIV_ROUND_UP, Michael Tokarev, 2016/06/05
- [Qemu-trivial] [PULL 03/52] docs: "specify" spell fix, Michael Tokarev, 2016/06/05
- [Qemu-trivial] [PULL 33/52] host-utils: Prefer 'false' for bool type, Michael Tokarev, 2016/06/05
- [Qemu-trivial] [PULL 49/52] linux-user: Use DIV_ROUND_UP, Michael Tokarev, 2016/06/05