[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] scsi-disk: Use (unsigned long) typecasts when
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-trivial] [PATCH] scsi-disk: Use (unsigned long) typecasts when using "%lu" format string |
Date: |
Mon, 13 Jun 2016 12:03:38 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 |
On 13/06/2016 10:10, Thomas Huth wrote:
> Some source code analyzers like cppcheck spill out a warning if
> the sign of the argument does not match the format string.
>
> Ticket: https://bugs.launchpad.net/qemu/+bug/1589564
> Signed-off-by: Thomas Huth <address@hidden>
> ---
> hw/scsi/scsi-disk.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
> index 1881969..36f8a85 100644
> --- a/hw/scsi/scsi-disk.c
> +++ b/hw/scsi/scsi-disk.c
> @@ -2060,13 +2060,13 @@ static int32_t scsi_disk_emulate_command(SCSIRequest
> *req, uint8_t *buf)
> }
> break;
> case MODE_SELECT:
> - DPRINTF("Mode Select(6) (len %lu)\n", (long)r->req.cmd.xfer);
> + DPRINTF("Mode Select(6) (len %lu)\n", (unsigned
> long)r->req.cmd.xfer);
> break;
> case MODE_SELECT_10:
> - DPRINTF("Mode Select(10) (len %lu)\n", (long)r->req.cmd.xfer);
> + DPRINTF("Mode Select(10) (len %lu)\n", (unsigned
> long)r->req.cmd.xfer);
> break;
> case UNMAP:
> - DPRINTF("Unmap (len %lu)\n", (long)r->req.cmd.xfer);
> + DPRINTF("Unmap (len %lu)\n", (unsigned long)r->req.cmd.xfer);
> break;
> case VERIFY_10:
> case VERIFY_12:
> @@ -2080,7 +2080,7 @@ static int32_t scsi_disk_emulate_command(SCSIRequest
> *req, uint8_t *buf)
> case WRITE_SAME_16:
> DPRINTF("WRITE SAME %d (len %lu)\n",
> req->cmd.buf[0] == WRITE_SAME_10 ? 10 : 16,
> - (long)r->req.cmd.xfer);
> + (unsigned long)r->req.cmd.xfer);
> break;
> default:
> DPRINTF("Unknown SCSI command (%2.2x=%s)\n", buf[0],
>
Queued, thanks.
Paolo