[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PULL 25/27] win32: don't run subprocess tests on Mingw32
From: |
Michael Tokarev |
Subject: |
[Qemu-trivial] [PULL 25/27] win32: don't run subprocess tests on Mingw32 platform |
Date: |
Wed, 14 Sep 2016 10:58:51 +0300 |
From: Eduardo Habkost <address@hidden>
On Tue, Jun 14, 2016 at 04:44:57PM +0100, Daniel P. Berrange wrote:
> The g_test_trap_subprocess() method does not work on the
> Mingw32 platform, causing the test-qdev-global-props
> test case to abort
>
> (test-logging.exe:230): GLib-ERROR **: g_test_trap_subprocess()
> failed: Failed to execute helper program (No such file or directory)
>
> This failure was introduced a while ago in
>
> commit 2177801a4899bf29108b3d471417a5b4d701ec29
> Author: Eduardo Habkost <address@hidden>
> Date: Fri Aug 8 16:03:27 2014 -0300
>
> test-qdev-global-props: Run tests on subprocess
>
> Modify the configure time check to avoid enabling this feature
> on Mingw, rather than trying to rewrite the test to avoid this
> feature.
I would do the following instead, just in case we have extra code
looking at $glib_subprocess one day.
Signed-off-by: Eduardo Habkost <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index d4388a6..e6b2c45 100755
--- a/configure
+++ b/configure
@@ -3023,7 +3023,7 @@ fi
# g_test_trap_subprocess added in 2.38. Used by some tests.
glib_subprocess=yes
-if ! $pkg_config --atleast-version=2.38 glib-2.0; then
+if test "$mingw32" = "yes" || ! $pkg_config --atleast-version=2.38 glib-2.0;
then
glib_subprocess=no
fi
--
2.1.4
- [Qemu-trivial] [PULL 00/27] Trivial patches for 2016-09-14, Michael Tokarev, 2016/09/14
- [Qemu-trivial] [PULL 13/27] ivshmem: Delete duplicate debug message, Michael Tokarev, 2016/09/14
- [Qemu-trivial] [PULL 02/27] tcg: Remove duplicate header includes, Michael Tokarev, 2016/09/14
- [Qemu-trivial] [PULL 09/27] MAINTAINERS: Add some header files to the PC chipset section, Michael Tokarev, 2016/09/14
- [Qemu-trivial] [PULL 14/27] timer: update comments, Michael Tokarev, 2016/09/14
- [Qemu-trivial] [PULL 04/27] MAINTAINERS: Add include/hw/unicore32/ to UniCore32 section, Michael Tokarev, 2016/09/14
- [Qemu-trivial] [PULL 25/27] win32: don't run subprocess tests on Mingw32 platform,
Michael Tokarev <=
- [Qemu-trivial] [PULL 06/27] MAINTAINERS: Add include/hw/sh4/ to SH4 section, Michael Tokarev, 2016/09/14
- [Qemu-trivial] [PULL 18/27] curl: Operate on zero-length file, Michael Tokarev, 2016/09/14
- [Qemu-trivial] [PULL 22/27] tricore: remove useless cast, Michael Tokarev, 2016/09/14
- [Qemu-trivial] [PULL 01/27] Remove remainders of HPPA backend, Michael Tokarev, 2016/09/14
- [Qemu-trivial] [PULL 23/27] fw_cfg: remove useless casts, Michael Tokarev, 2016/09/14
- [Qemu-trivial] [PULL 07/27] MAINTAINERS: Add include/sysemu/cpus.h, Michael Tokarev, 2016/09/14
- [Qemu-trivial] [PULL 21/27] s390x: remove useless cast, Michael Tokarev, 2016/09/14
- [Qemu-trivial] [PULL 27/27] mptsas: change .realize function name, Michael Tokarev, 2016/09/14
- [Qemu-trivial] [PULL 03/27] ui/console: Fix non-working backspace key in monitor of gtk UI, Michael Tokarev, 2016/09/14
- [Qemu-trivial] [PULL 10/27] MAINTAINERS: Fix up F: entry bit rot, Michael Tokarev, 2016/09/14