[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PULL 18/31] lm32: milkymist-tmu2: fix another integer ov
From: |
Michael Tokarev |
Subject: |
[Qemu-trivial] [PULL 18/31] lm32: milkymist-tmu2: fix another integer overflow |
Date: |
Tue, 24 Jan 2017 12:39:22 +0300 |
From: Peter Maydell <address@hidden>
Don't truncate the multiplication and do a 64 bit one instead
because the result is stored in a 64 bit variable.
This fixes a similar coverity warning to commit 237a8650d640,
in a similar way, and is the other half of the fix for
coverity CID 1167561.
Signed-off-by: Peter Maydell <address@hidden>
Acked-by: Michael Walle <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
hw/display/milkymist-tmu2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/display/milkymist-tmu2.c b/hw/display/milkymist-tmu2.c
index 5c666f9..920374b 100644
--- a/hw/display/milkymist-tmu2.c
+++ b/hw/display/milkymist-tmu2.c
@@ -257,7 +257,7 @@ static void tmu2_start(MilkymistTMU2State *s)
glColor4f(m, m, m, (float)(s->regs[R_ALPHA] + 1) / 64.0f);
/* Read the QEMU dest. framebuffer into the OpenGL framebuffer */
- fb_len = 2 * s->regs[R_DSTHRES] * s->regs[R_DSTVRES];
+ fb_len = 2ULL * s->regs[R_DSTHRES] * s->regs[R_DSTVRES];
fb = cpu_physical_memory_map(s->regs[R_DSTFBUF], &fb_len, 0);
if (fb == NULL) {
glDeleteTextures(1, &texture);
--
2.1.4
- [Qemu-trivial] [PULL 25/31] hw/display/framebuffer.c: Avoid overflow for framebuffers > 4GB, (continued)
- [Qemu-trivial] [PULL 25/31] hw/display/framebuffer.c: Avoid overflow for framebuffers > 4GB, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 03/31] README: Add linux to macOS build info, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 30/31] usb: Set category and description of the MTP device, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 22/31] util/mmap-alloc: check parameter before using, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 16/31] doc/usb2: fix typo, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 21/31] vfio: remove a duplicated word in comments, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 05/31] include: Fix typos found by codespell, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 07/31] qemu-options: cleanup duplicated help message for kernel_irqchip, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 29/31] gdbstub.c: update old error report statements, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 27/31] scsi-disk: add 'fall through' comment to switch VERIFY cases, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 18/31] lm32: milkymist-tmu2: fix another integer overflow,
Michael Tokarev <=
- [Qemu-trivial] [PULL 08/31] usb: Fix typo in documentation, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 23/31] util/mmap-alloc: refactor a little bit for readability, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 04/31] Fix documentation and some comments (article, grammar), Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 20/31] docs: sync pci-ids.txt, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 26/31] Drop duplicate display option documentation, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 24/31] win32: use glib gpoll if glib >= 2.50, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 14/31] block: remove dead check, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 10/31] object: make some funcs static, Michael Tokarev, 2017/01/24
- Re: [Qemu-trivial] [Qemu-devel] [PULL 00/31] Trivial patches for 2017-01-24, no-reply, 2017/01/24
- Re: [Qemu-trivial] [Qemu-devel] [PULL 00/31] Trivial patches for 2017-01-24, Peter Maydell, 2017/01/24