[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] nbd-client: Use correct macro parenthesizatio
From: |
Eric Blake |
Subject: |
Re: [Qemu-trivial] [PATCH] nbd-client: Use correct macro parenthesization |
Date: |
Mon, 18 Sep 2017 17:42:24 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 09/18/2017 05:13 PM, Philippe Mathieu-Daudé wrote:
> Hi Eric,
>
> On 09/18/2017 06:46 PM, Eric Blake wrote:
>> If 'bs' is a complex expression, we were only casting the front half
>> rather than the full expression. Luckily, none of the callers were
>> passing bad arguments, but it's better to be robust up front.
>>
>> Signed-off-by: Eric Blake <address@hidden>
>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
>
> Any magic cocci script to verify there aren't no more?
I don't know if cocci can do it; checkpatch tries to check whether macro
arguments are parenthesized, but even that's prone to missing things. I
just spotted this particular one while reviewing a related patch.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature