[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] dma/i82374: avoid double creation of i82374 d
From: |
Michael Tokarev |
Subject: |
Re: [Qemu-trivial] [PATCH] dma/i82374: avoid double creation of i82374 device |
Date: |
Mon, 25 Sep 2017 13:54:08 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
25.09.2017 12:26, Eduardo Otubo wrote:
> On Mon, Sep 25, 2017 at 11:11:37AM +0200, Paolo Bonzini wrote:
>> On 24/09/2017 23:02, Michael Tokarev wrote:
>>> 15.09.2017 12:06, Eduardo Otubo wrote:
>>>> QEMU fails when used with the following command line:
>>>>
>>>> ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device
>>>> i82374
>>>> qemu-system-ppc64: hw/isa/isa-bus.c:110: isa_bus_dma: Assertion
>>>> `!bus->dma[0] && !bus->dma[1]' failed.
>>>> Aborted (core dumped)
>>>>
>>>> The 40p machine type already creates the device i82374. If specified in the
>>>> command line, it will try to create it again, hence generating the error.
>>>> The
>>>> function isa_bus_dma() isn't supposed to be called twice for the same bus.
>>>> One
>>>> way to avoid this problem is to set user_creatable=false.
>>>
>>> Applied to -trivial, thanks!
>>
>> Eduardo, weren't you going to send a version that propagates Error*
>> correctly instead?
>
> Yes, that's correct. I can revert this patch with the error
> propagation patch as well, if you guys don't mind.
Hmm. After reading the original discussion I concluded this patch
is okay. I can remove it right now before the series has been
applied, together with another tiny change.
Thanks,
/mjt
- [Qemu-trivial] [PATCH] dma/i82374: avoid double creation of i82374 device, (continued)