[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] build-sys: make help could have
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] build-sys: make help could have 'modules' target |
|
Date: |
Wed, 7 Mar 2018 15:46:39 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 07/03/2018 02:38, Fam Zheng wrote:
> On Tue, 03/06 17:17, Marc-André Lureau wrote:
>> Available when configure --enable-modules.
>>
>> Signed-off-by: Marc-André Lureau <address@hidden>
>> ---
>> Makefile | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/Makefile b/Makefile
>> index 9a75c48ae0..5d9ef3b8fd 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -1046,6 +1046,9 @@ include $(SRC_PATH)/tests/vm/Makefile.include
>> help:
>> @echo 'Generic targets:'
>> @echo ' all - Build all'
>> +ifdef CONFIG_MODULES
>> + @echo ' modules - Build all modules'
>> +endif
>
> Hi Marc-André,
>
> I'd just remove the 'ifdef' condition and include the line everywhere, since
> this is the help. The behavior is fine even without running ./configure:
>
> $ make modules
> make: Nothing to be done for 'modules'.
> $ make all
> make: Nothing to be done for 'all'.
>
> Fam
>
Queued, thanks.
Paolo