[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH 1/4] ui: add qapi parser for -dis
From: |
Eric Blake |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH 1/4] ui: add qapi parser for -display |
Date: |
Thu, 19 Apr 2018 10:57:12 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 04/19/2018 08:20 AM, Gerd Hoffmann wrote:
> Add parse_display_qapi() function which parses the -display command line
> using a qapi visitor for DisplayOptions. Wire up as default catch in
> parse_display().
>
> Improves the error message for unknown display types.
>
> Also enables json as -display argument, i.e. -display "{ 'type': 'gtk' }"
>
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> +
> + /*
> + * We don't have any dynamically allocated stuff inside
> + * DisplayOptions, so we can simply copy the struct content and
> + * free opts without ending up with pointers pointing into
> + * nowhere.
> + */
> + dpy = *opts;
> + qapi_free_DisplayOptions(opts);
That's risky; would it be better to use QAPI_CLONE_MEMBERS() to not have
to worry about if we add a pointer in the future?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature