Re: [Quilt-dev] diff and dos line endings

[Josh Boyer]

On Sat, 2005-04-09 at 19:11 +0200, Andreas Gruenbacher wrote:
> On Saturday 09 April 2005 14:37, Josh Boyer wrote:
> > Hi,
> >
> > I've been working on getting quilt packaged for Fedora Extras and one of
> > the users brought the following to my attention:
> >
> > https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=154283
> >
> > To summarize, when using the --show-c-functions option on files with dos
> > line endings diff generates patches that no longer apply cleanly.
> 
> Looks like a GNU diff bug, so it should be fixed in GNU diff I would say.

Yes.  That's what the bug has been opened against.

> 
> > I know this isn't a problem with quilt, but the question was raised as
> > to whether the --show-c-functions option should be in the default
> > quiltrc file.  Any thoughts?
> 
> In my opinion, --show-c-functions is usually a good idea, and it's more often 
> useful than not.

I agree.  I just thought I would ask in case someone thought it was
important enough to try and work around the problem for projects that
use dos line endings.  Those are probably fairly rare, so it doesn't
make much sense I guess.

thx,
josh