Re: [Quilt-dev] trailing whitespace

[Andrew Morton]

Andreas Gruenbacher <address@hidden> wrote:
>
> On Friday 29 April 2005 01:26, Andrew Morton wrote:
>  > I think it would be good if quilt were to warn users when their patches add
>  > trailing whitespace.  It's a silly thing to do.
> 
>  Agreed.
> 
>  > In patch-scripts I run this during `refpatch'
>  >
>  > check_patch()
>  > {
>  >    if grep "^+.*[  ]$" $P/patches/$(stripit $1).patch
>  >    then
>  >            echo warning: $1 adds trailing whitespace
>  >    fi
>  > }
> 
>  So you also print the offending lines -- I'd rather not.

Sure - it's pretty useless.

> How about adding a 
>  --strip-whitespace option to the refresh command? Those who want can then 
>  also add it to .quiltrc.

Sounds good.

>  Index: quilt/refresh.in
>  ===================================================================
>  --- quilt/refresh.in
>  +++ quilt/refresh.in
>  @@ -72,7 +72,8 @@
>       exit $status
>   }
>   
>  -options=`getopt -o p:uU:cC:fh --long no-timestamps,diffstat,backup,sort -- 
>  "$@"`

Your mail client is wordwrapping stuff.