quilt-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Quilt-dev] [RFC][PATCH] quilt commit command


From: Josh Boyer
Subject: Re: [Quilt-dev] [RFC][PATCH] quilt commit command
Date: Fri, 20 May 2005 17:15:30 -0500

On Fri, 2005-05-20 at 14:31 -0700, randy_dunlap wrote:
> On Thu, 19 May 2005 12:46:28 +0200 Andreas Gruenbacher wrote:
> 
> | On Thursday 19 May 2005 11:28, Martin Quinson wrote:
> | > > Ok, I'm not too concerned with the name.  It's the functionality of the
> | > > command that I would like to get added.  Basically, you're done with a
> | > > patch and now you want to have quilt "forget" a patch is applied.
> | > >
> | > > It could be called "quilt finalize" perhaps?  I'm open to suggestions.
> | >
> | > If Andreas approves the functionality (which is good, IMHO), finalize 
> would
> | > be a much better name. But there's a "if" in my sentence... ;)
> | 
> | "drop" came to my mind first ;)
> 
> ditto for me.  If there was any need to distinguish between
> dropped-because-merged and dropped-because-rejected, then I
> would use "merged" and "rejected", sort of combining status
> and command name.

Hmm, but a rejected patch isn't one that is going to be left applied,
right?

And I didn't want to use "merged", not because it doesn't fit, but more
because most people view a merged patch as something they've sent off
and it got permanently applied to some other tree.

I'm still open to name changes.  It'll be a couple days before I can
generate a new patch (which basically just renames the command), so if
there is a consensus on something other than "drop" that will work too.

josh




reply via email to

[Prev in Thread] Current Thread [Next in Thread]