Re: [Quilt-dev] [PATCH] Enhanced decoration for "series -v" command

[Peter Williams]

Yasushi SHOJI wrote:
> At Sat, 11 Jun 2005 12:52:21 +1000,
> Peter Williams wrote:
>
> > Andreas Gruenbacher wrote:
> >
> > > On Friday 10 June 2005 08:21, Peter Williams wrote:
> > >
> > >
> > > > I am the author of a PyGTK GUI wrapper ( see
> > > > <http://freshmeat.net/projects/gquilt/>) for quilt and it has been
> > > > suggested to me that the panel containing the display of the patch
> > > > series could be enhanced by having it display (for applied patches)
> > > > whether each patch needs refreshing or not.
> > >
> > >
> > > Looks nice. It seems the Push and Pop icons point in the wrong direction wrt. 
> > > the series file (which has its top at the bottom)?
> >
> > You're the second person to say that and I don't understand as the push 
>
>
> I'm the 3rd, then.  This is the first thing I noticed when I looked at
> the image on freshmeat page.
> http://freshmeat.net/screenshots/54225/58238/
>
> I had even checked the quilt ml archive to see if anyone was saying
> anything about this icon.
>
> my 2 cents

OK.  That rules out the "looking at the wrong image" explanation so it 
looks like a difference in thought processes.

In my view, a normal stack has new items put on the top and a down arrow 
would symbolize the push action.  I.e. pushing an item down onto the top 
of the stack.

However, in quilt, the push operation is being applied to a series and 
the new item is being pushed up onto the bottom of the the series so an 
up arrow is the appropriate symbol.

If you look at this in conjunction with the displayed patch list the up 
arrow also makes sense as it depicts the movement of the pushed patch 
from the greyed out unapplied patches at the bottom of the list to the 
applied patches at the top of the list.

Am I the only one who sees this as logical?
Peter
--
Peter Williams                                   address@hidden

"Learning, n. The kind of ignorance distinguishing the studious."
 -- Ambrose Bierce