[Quilt-dev] quilt diff and stderr

[Jean Delvare]

Hi all,

The "diff" command of quilt currently prints a message on stderr in
certain circumstances:

More recent patches modify files in patch X

And this is true, but I don't quite see how this constitutes an error.
This seems to be more of an additional information of arguable interest
than an error. Or am I missing something?

Actually, I don't understand by what rationale this message is returned
by "quilt diff". The diff command is about extracting/combining diffs
out of the set of currently applied patches, it's not about dependencies
between patches. The files, patches and graph commands can answer that
kind of question much more efficiently.

I am concerned about this error message confusing front-ends to quilt,
as it will trigger even when no actual error happened. Due to the
limited interest the message seems to have, the most simple fix would be
to simply drop it.

Are there objections to me doing so?

Thanks.

Index: quilt/diff.in
===================================================================
RCS file: /cvsroot/quilt/quilt/quilt/diff.in,v
retrieving revision 1.51
diff -u -r1.51 diff.in
--- quilt/diff.in       29 Jun 2005 15:52:51 -0000      1.51
+++ quilt/diff.in       1 Sep 2005 18:28:05 -0000
@@ -395,7 +395,6 @@
                new_file="$file"
        else
                new_file="$(backup_file_name $next_patch $file)"
-               files_were_shadowed=1
        fi
 
        do_diff "$file" "$old_file" "$new_file" \
@@ -408,12 +407,6 @@
        fi
 done
 
-if [ -n "$files_were_shadowed" ]
-then
-       printf $"More recent patches modify files in patch %s\n" \
-              "$(print_patch $last_patch)" >&2
-       die 1
-fi
 die 0
 ### Local Variables:
 ### mode: shell-script



-- 
Jean Delvare