quilt-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Quilt-dev] [PATCH] backup-files.c fixes


From: Andreas Gruenbacher
Subject: Re: [Quilt-dev] [PATCH] backup-files.c fixes
Date: Wed, 25 Jan 2006 19:26:32 +0100
User-agent: KMail/1.8.2

On Wednesday 25 January 2006 19:05, Markus F.X.J. Oberhumer wrote:
> Indeed, you are right. Still it seems that the optimization might make
> sense in the second ("what_restore") case.

No, the backup file may also only have a link count of one. There's another 
weakness in the code though: the backup file is only unlinked after 
ensure_nolinks was called, at which point a copy has already been created. 
I'm fixing that as well now.

> Yes. BTW you usually never see these on Linux, but EINTR and EAGAIN tend to
> pop up on BSD systems at unexpected times.

Indeed. EINTR shouldn't occur out of nothing though.

Andreas.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]