Re: [Quilt-dev] quilt remove gone

[Peter Williams]

Dirk Behme wrote:
> Arnaud Patard wrote:
> > Hi,
> >
> > I was testing current development code and found out that 'quilt remove'
> > has been replaced by 'quilt revert'. I don't know what are the exacts
> > reasons for this but from my point of view, it's a broken change :(
> >
> > With 'quilt remove', it was possible to remove a file from a patch,
> > while with 'quilt revert' it's not. For instance, one creates a new file
> > with 'quilt edit' and then found out, it's not needed. So, I was using
> > 'quilt remove' to remove it. With 'quilt revert', it's a nop.
> >
> > Can someone help me and tell me how am I supposed to remove a file from
> > a patch now that 'quilt remove' is gone ?
>
> Yes, 'quilt revert' doesn't work for me, too, to remove a file. E.g.:
>
> -- cut --
>  > quilt --version
> 0.47
>  > quilt files
> Makefile
>  > quilt revert Makefile
> File Makefile is unchanged
>  > quilt files
> Makefile
>  > quilt diff
> Index: u-boot-main/Makefile
> ===================================================================
> --- u-boot-main.orig/Makefile
> +++ u-boot-main/Makefile
> @@ -1,4 +1,4 @@
> -#
> +#
>  # (C) Copyright 2000-2008
>  # Wolfgang Denk, DENX Software Engineering, address@hidden
>  #
>  >
> -- cut --
>
> Seems to me that this "File Makefile is unchanged" as reaction to 'quilt 
> revert <file>' is just wrong? Any hint how to remove a file from a patch 
> without 'quilt remove'?
>
> Thanks
>
> Dirk
>
>
>
> _______________________________________________
> Quilt-dev mailing list
> address@hidden
> http://lists.nongnu.org/mailman/listinfo/quilt-dev

Is anything being done about this problem?

The way I see it the current "revert" is useful (i.e. remove unrefreshed 
changes to files) but so was "remove" (i.e. remove ALL changes to the 
file and remove it from the patch).

So why not keep "revert" as it is but restore the old "remove" function 
as well?

Thanks
Peter
PS Whatever, the help message/man page for "revert" needs a more 
explicit explanation of its function.
--
Peter Williams                                   address@hidden

"Learning, n. The kind of ignorance distinguishing the studious."
 -- Ambrose Bierce