[Quilt-dev] Re: [PATCH] fix pager on broken pipe

[Bert Wesarg]

On Mon, Dec 14, 2009 at 16:22, Jean Delvare <address@hidden> wrote:
> Le lundi 14 décembre 2009 15:23, Bert Wesarg a écrit :
>> Quitting the pager while quilt is producing input caused write error messages
>> on the consolo. Fix this by using the default SIGPIPE, which cause quilt to
>> quit.

Quitting the pager while quilt is producing output is causing write
error messages
on the console. Fix this by using the default SIGPIPE, which will quit quilt.


>>
>> Signed-off-by: Bert Wesarg <address@hidden>
>>
>> ---
>>  quilt/scripts/patchfns.in |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git c/quilt/scripts/patchfns.in i/quilt/scripts/patchfns.in
>> index aef1a54..fbe8f7b 100644
>> --- c/quilt/scripts/patchfns.in
>> +++ i/quilt/scripts/patchfns.in
>> @@ -1006,7 +1006,7 @@ wait_for_pager_signal()
>>  {
>>       remove_exit_handler wait_for_pager
>>       wait_for_pager
>> -     trap - INT HUP TERM QUIT PIPE
>> +     trap - INT HUP TERM QUIT
>>  }
>>
>>  # Spawn pager process and redirect the rest of our output to it
>> @@ -1034,7 +1034,7 @@ setup_pager()
>>       pager_pid=$!
>>       exec > "$pager_fifo"
>>
>> -     trap wait_for_pager_signal INT HUP TERM QUIT PIPE
>> +     trap wait_for_pager_signal INT HUP TERM QUIT
>>       add_exit_handler wait_for_pager
>>  }
>>
>
> Seems to fix the problem for me, indeed. If nobody objects, and if
> I don't notice any problem in the next few days, I'll commit this
> fix, thanks.
Can you fix a few typos in the commit message than (see above). Thanks.

>
> --
> Jean Delvare
> Suse L3
>