quilt-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Quilt-dev] [PATCH] Skip non-files when selecting the SERIES file


From: Raphael Hertzog
Subject: Re: [Quilt-dev] [PATCH] Skip non-files when selecting the SERIES file
Date: Sun, 24 Jan 2010 21:24:52 +0100
User-agent: Mutt/1.5.20 (2009-06-14)

Hi,

On Sun, 24 Jan 2010, Jean Delvare wrote:
> > -if [ "${QUILT_SERIES:0:1}" = / ]
> > +if [ "${QUILT_SERIES:0:1}" = / -a \( -f $QUILT_SERIES -o ! -e 
> > $QUILT_SERIES \) ]
> 
> This doesn't make sense to me. If the series file is an absolute
> path, then none of the cases below can apply. If the absolute path
> points to a non-file then this is a user error and we should report
> it and abort immediately.

OK, then no need to error out here, the appropriate checks are already in
place elsewhere in the code (commit
8c3585bce0470d471d2179cbdfeead133dfdf867). Updated patch attached.

Cheers,
-- 
Raphaël Hertzog

Attachment: 0001-Skip-non-files-when-selecting-the-SERIES-file.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]