Re: [Quilt-dev] [PATCH] patchfns: Drop shebang statement

[Jean Delvare]

On Saturday 12 March 2011 03:46:57 pm Jean Delvare wrote:
> patchfns is meant to be sourced from other scripts, rather than
> executed on its own. As a matter of fact, it's not even executable.
> So we don't need the #! statement at the beginning of this file.
> 
> Signed-off-by: Jean Delvare <address@hidden>
> Cc: Raphael Hertzog <address@hidden>
> ---
> Any objection? Am I missing something?

I did indeed miss something: the @BASH@ marker was used to identify
bash code as such for the purpose of internationalization. So I will
have to apply the following fix:

--- quilt.orig/Makefile.in
+++ quilt/Makefile.in
@@ -174,7 +174,8 @@ po/quilt.pot: $(filter-out debian/contro
                                          $(wildcard */*/*.in))
        rm -f po/quilt.pot; touch po/quilt.pot
        for file in $+ ; do                                             \
-         if test -n "`$(SED) -ne '1{ /@BASH''@/p }' $$file`"; then     \
+         if test -n "`$(SED) -ne '1{ /@BASH''@/p }' $$file`"           \
+              -o "$$file" = quilt/scripts/patchfns.in; then            \
            $(BASH) --dump-po-strings $$file ;                          \
          elif test -n "`$(SED) -ne '1{ /@PERL''@/p }' $$file`"; then   \
            $(XGETTEXT) --from-code=UTF-8 --omit-header --language=Perl \


-- 
Jean Delvare
Suse L3