[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Quilt-dev] [PATCH 04/39] BSD compatibility: rmdir
From: |
Jean Delvare |
Subject: |
[Quilt-dev] [PATCH 04/39] BSD compatibility: rmdir |
Date: |
Sat, 19 Mar 2011 10:52:34 +0100 |
User-agent: |
quilt/0.48-17.1 |
Use rmdir -p instead of open-coding it. The more complex code was
maybe needed to properly handle symbolic links, but we know that
there won't be symbolic links in the backup directory, so the extra
complexity isn't needed.
Signed-off-by: Jean Delvare <address@hidden>
Reviewed-by: Raphael Hertzog <address@hidden>
---
quilt/scripts/backup-files.in | 27 +++------------------------
1 file changed, 3 insertions(+), 24 deletions(-)
--- a/quilt/scripts/backup-files.in
+++ b/quilt/scripts/backup-files.in
@@ -117,14 +117,7 @@ process_file() {
$ECHO "Removing $file"
if [ -z "$OPT_KEEP_BACKUP" ]; then
rm "$backup"
- while [ -d "${backup%/*}" ] && ! [ -L
"${backup%/*}" ]
- do
- backup="${backup%/*}"
- rmdir --ignore-fail-on-non-empty
"$backup" 2>/dev/null
- if [ -d "$backup" ]; then
- break
- fi
- done
+ rmdir -p "${backup%/*}" 2> /dev/null || true
fi
else
$ECHO "Restoring $file"
@@ -142,14 +135,7 @@ process_file() {
if [ -z "$OPT_KEEP_BACKUP" ]; then
rm "$backup"
- while [ -d "${backup%/*}" ] && ! [ -L
"${backup%/*}" ]
- do
- backup="${backup%/*}"
- rmdir --ignore-fail-on-non-empty
"$backup" 2>/dev/null
- if [ -d "$backup" ]; then
- break
- fi
- done
+ rmdir -p "${backup%/*}" 2> /dev/null || true
fi
if [ -n "$OPT_TOUCH" ]; then
touch "$file"
@@ -159,14 +145,7 @@ process_file() {
if [ -e "$backup" ]; then
rm "$backup"
fi
- while [ -d "${backup%/*}" ] && ! [ -L "${backup%/*}" ]
- do
- backup="${backup%/*}"
- rmdir --ignore-fail-on-non-empty "$backup" 2>/dev/null
- if [ -d "$backup" ]; then
- break
- fi
- done
+ rmdir -p "${backup%/*}" 2> /dev/null || true
elif [ -z "$OPT_WHAT" ]; then
if [ -e "$file" ] && [ -n "$OPT_NOLINKS" ]; then
ensure_nolinks "$file"
- [Quilt-dev] [PATCH 36/39] backup-files: Drop support for -L on restore, (continued)
- [Quilt-dev] [PATCH 36/39] backup-files: Drop support for -L on restore, Jean Delvare, 2011/03/19
- [Quilt-dev] [PATCH 16/39] backup-files: Optimize backup, Jean Delvare, 2011/03/19
- [Quilt-dev] [PATCH 06/39] backup-files: Drop suffix option, Jean Delvare, 2011/03/19
- [Quilt-dev] [PATCH 28/39] backup-files: Separate lists for empty and non-empty files, Jean Delvare, 2011/03/19
- [Quilt-dev] [PATCH 10/39] backup-files: Speed up ensure_nolinks, Jean Delvare, 2011/03/19
- [Quilt-dev] [PATCH 35/39] backup-files: Inline restore_fast, Jean Delvare, 2011/03/19
- [Quilt-dev] [PATCH 20/39] backup-files: Batch mass restore, Jean Delvare, 2011/03/19
- [Quilt-dev] [PATCH 31/39] backup-files: New function for copy, Jean Delvare, 2011/03/19
- [Quilt-dev] [PATCH 37/39] backup-files: Drop support for backup removal, Jean Delvare, 2011/03/19
- [Quilt-dev] [PATCH 08/39] backup-files: Drop variable progname, Jean Delvare, 2011/03/19
- [Quilt-dev] [PATCH 04/39] BSD compatibility: rmdir,
Jean Delvare <=
- [Quilt-dev] [PATCH 32/39] backup-files: Separate function copy_many, Jean Delvare, 2011/03/19
- [Quilt-dev] [PATCH 39/39] backup-files: Skip echo-only loops in silent mode, Jean Delvare, 2011/03/19
- [Quilt-dev] [PATCH 34/39] backup-files: Clarify command line options, Jean Delvare, 2011/03/19
- [Quilt-dev] [PATCH 38/39] backup-files: Keep /dev/null opened, Jean Delvare, 2011/03/19