Re: [Quilt-dev] [PATCH] Fix test for GNU patch version

[Jean Delvare]

On Tuesday 22 March 2011 07:08:30 pm Andreas Gruenbacher wrote:
> On Tuesday 22 March 2011 18:41:47 Jean Delvare wrote:
> > Hi Andreas,
> >
> > On Monday 21 March 2011 11:05:18 pm Andreas Gruenbacher wrote:
> > > On Monday 21 March 2011 22:11:39 Jean Delvare wrote:
> > > > We currently ask for GNU patch >= 2.4, but the test suite
> > > > doesn't actually pass with GNU patch 2.4. It passes with GNU
> > > > patch 2.5 with minor edits to be more tolerant with the exact
> > > > output of "patch".
> > >
> > > Can you check for version 2.5.3 and up instead?  Since at least
> > > then, patch understands the QUOTING_STYLE environment variable
> > > which tests/test.quiltrc uses.
> >
> > I can, but what's the purpose of this test? The edits to the test
> > suite are trivial to get patch 2.5 to pass (as you found out, just
> > some tolerance on quotes, as we already have in other places), so
> > we can just do that. Requesting 2.5.3 instead just for quotes in
> > the output seems unfair.
> 
> The additional regular expression matching makes the test suite more
>  ugly, but we are already matching for optional quotes in some
>  places.  So go ahead ...

If the readability of the test cases worries you to this degree, I guess 
it would be possible to have the test runner ignore all quotes in reply 
to commands? Either unconditionally, or after testing for the presence 
of an old version of GNU patch not honoring QUOTING_STYLE?

-- 
Jean Delvare
Suse L3