quilt-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Quilt-dev] 0.50 in Debian + Simple patch for inclusion: Fix manpage


From: Raphael Hertzog
Subject: Re: [Quilt-dev] 0.50 in Debian + Simple patch for inclusion: Fix manpage generation under dash
Date: Tue, 3 Jan 2012 16:23:52 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

On Tue, 03 Jan 2012, Jean Delvare wrote:
> Note that the bare 0.50 has a couple of known issues, so I hope you 
> picked the patches from the git repository. In particular 
> 00e551287a23749c7d1b0bc3e25741a5bd360bcd and 
> a8eae6b84f446e9cda14977acba88ead040a4600.

Those are pretty minor, we can wait 0.51 since it's supposed to happen
before the next Debian freeze. :)

> > The code also uses a bashism ($'') but it's not really needed with
> > GNU sed at least (it understands \t and \n) so drop it and avoid some
> > painful double escaping.
> 
> I assume that $'' isn't supported by dash and this is why you want to 
> get rid of it?

Yes. Alternatively you must fix the Makefile to explicity record that
it requires bash.

SHELL = /bin/bash
or
SHELL = bash

> I don't think we currently require GNU sed. Have you tested your changes 
> on BSD or Solaris? If we now need sed to support \t and \n, it would be 
> great to test this during configure to avoid a mysterious or even silent 
> failure during the build. 

I don't have any BSD or Solaris system to test this, sorry. So, no, I
haven't tested those changes on BSD or Solaris.

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Pre-order a copy of the Debian Administrator's Handbook and help
liberate it: http://debian-handbook.info/liberation/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]