Re: [Quilt-dev] [PATCH 1/4] Ensure quilt(1) documents the correct patches directory

[Andreas Gruenbacher]

On Fre, 2012-02-24 at 00:27 +0100, Raphaël Hertzog wrote:
> From: Julien Viard de Galbert <address@hidden>
> 
> Within the Debian source package, .pc/quilt_patches ensures that

        That should be .pc/.quilt_patches here.

As I look at this, I notice that commit ebbbdc87 which introduces
this .pc/.quilt_patches and .pc/.quilt_series stuff is a little stupid:

+if [ -r $QUILT_PC/.quilt_patches ]
+then
+       : ${QUILT_PATCHES:=$(< $QUILT_PC/.quilt_patches)}
+else
+       : ${QUILT_PATCHES:=patches}
+fi
+if [ -r $QUILT_PC/.quilt_series ]
+then
+       : ${QUILT_SERIES:=$(< $QUILT_PC/.quilt_series)}
+else
+       : ${QUILT_SERIES:=series}
+fi

We only need to check if $QUILT_PC/.quilt_patches exists if
QUILT_PATCHES is unset, like this (and similar for
$QUILT_PC/.quilt_series):

if [ -z "$QUILT_PATCHES" ]
then
        if [ -r "$QUILT_PC/.quilt_patches" ]
        then
                QUILT_PATCHES=$(< "$QUILT_PC/.quilt_patches")
        else
                QUILT_PATCHES=patches
        fi
fi


Andreas