Re: [Quilt-dev] [PATCH] Boost the speed of the series, applied and unapplied commands

[Jean Delvare]

Hi Greg,

I find it amazing that you still can find the time to read the quilt-dev
list!

Le Friday 28 February 2014 à 09:38 -0800, Greg KH a écrit :
> On Fri, Feb 28, 2014 at 09:52:39AM +0100, Jean Delvare wrote:
> > The current implementation of the series, applied and unapplied
> > commands performs rather poorly, especially on large patch sets. To
> > make things worse, bash completion makes use of these commands, so
> > it becomes next to unusable on large patch sets.
> > 
> > Instead of looping over each patch, use the power of printf to print
> > everything in one go. Performance gains on a 15k patch series are
> > breathtaking:
> > 
> > series:    189.4 s -> 0.6 s
> > series -v:  92.9 s -> 0.6 s
> > applied:     3.5 s -> 0.1 s
> > unapplied:   3.9 s -> 0.1 s
> 
> Oh, that would be so nice to have, thanks so much for doing this.

You're welcome. The best part is that the performance boost comes with
an elegant code cleanup :-)

-- 
Jean Delvare
SUSE L3 Support