Re: [Quilt-dev] minor fixes for quilt.el

[Jean Delvare]

Hi,

Le Thursday 15 January 2015 à 15:40 +0000, event a écrit :
> I spotted two small issues in quilt.el:
> 1. quilt-find-dir goes to endless recursion it root is not '/'. This
> holds for files opened with tramp for example

What it "tramp"? I don't use emacs and I don't know the language this
file is written in, so I can't review this. If anyone else can comment
on it, that would be great. Satoru-san, maybe you can help?

> 2.typo in quilt-patch-list prevents patch select completion operation.

This is is pretty obvious, even I can see this needs to be fixed. It's
odd nobody spotted this before.

> diff --git a/lib/quilt.el b/lib/quilt.el
> index 6fe1c32..8a14530 100644
> --- a/lib/quilt.el
> +++ b/lib/quilt.el
> @@ -45,14 +45,14 @@
>        (or (getenv "QUILT_PATCHES")
>            "patches")))
>  
> -(defun quilt-find-dir (fn)
> +(defun quilt-find-dir (fn &optional prefn)
>    "Return the top level dir of quilt from FN."
> -  (if (or (not fn) (equal fn "/"))
> +  (if (or (not fn) (equal fn "/") (equal fn prefn))
>        nil
>      (let ((d (file-name-directory fn)))
>        (if (file-accessible-directory-p (concat d "/.pc"))
>         d
> -     (quilt-find-dir (directory-file-name d))))))
> +     (quilt-find-dir (directory-file-name d) d)))))
>  
>  (defun quilt-dir (&optional fn)
>    "Return the top level dir of quilt from FN.  FN is just a hint and find 
> from other way if FN is nil."
> @@ -126,7 +126,7 @@
>  
>  (defun quilt-patch-list ()
>    "Return the list of the name of patches."
> -  (quilt-cmd-to-list "seriess"))
> +  (quilt-cmd-to-list "series"))
>  
>  (defun quilt-files-affected (&optional first last)
>    "Return the file names which modified from FIRST to LAST."

Thanks,
-- 
Jean Delvare
SUSE L3 Support