[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Quilt-dev] [PATCH] faildiff.test: Fix for diffutils 3.4 and later
From: |
Jean Delvare |
Subject: |
Re: [Quilt-dev] [PATCH] faildiff.test: Fix for diffutils 3.4 and later |
Date: |
Tue, 13 Sep 2016 11:21:35 +0200 |
Hi Martin,
On Fri, 9 Sep 2016 17:47:33 +0200, Martin Quinson wrote:
> this seems sensible to refuse binary patches as we cannot use them.
> But I'm afraid that the detection method will not play well with
> translations. I don't have no better idea, unfortunately.
It doesn't seem to be a problem. I have a French locale (fr_FR.UTF-8)
and quilt is talking to me in French, but the output of diff is still
in English.
At the beginning of patchfns, we do:
ORIGINAL_LANG=$LANG
export LANG=POSIX
As I understand it, it means we can assume English output from
everything we call, except in the few cases where we explicitly restore
the original locale before the call.
--
Jean Delvare
SUSE L3 Support