Re: [Quilt-dev] missing Subject: in quilt mail

[Andreas Grünbacher]

2018-07-26 1:20 GMT+02:00 Randy Dunlap <address@hidden>:
> On 07/25/2018 03:58 PM, Andreas Grünbacher wrote:
>> Hi Randy,
>>
>> 2018-07-25 20:22 GMT+02:00 Randy Dunlap <address@hidden>:
>>> On 07/25/2018 10:56 AM, Randy Dunlap wrote:
>>>> Hi,
>>>>
>>>> [quilt v0.65]
>>>>
>>>> I don't usually use quilt mail to send patches, but I was just trying
>>>> to do that and keep having this error.
>>>>
>>>> It happens whether I use -M intro_file_name or just let quilt invoke
>>>> $EDITOR to generate an intro file:
>>>>
>>>> Introduction has no subject header (saved as /tmp/quilt.rXd573)
>>>>
>>>> and that file looks like this:
>>>> Message-Id: <address@hidden>
>>>> User-Agent: quilt/0.65
>>>> Date: Wed, 25 Jul 2018 10:01:18 -0700
>>>> From: address@hidden
>>>> To: address@hidden
>>>> Cc: address@hidden
>>>> Bcc:
>>>> Subject-Prefix: [PATCH @num@/@address@hidden
>>>> Subject: arc: some allmodconfig fixup patches
>>>>
>>>> Hi,
>>>>
>>>> Here are a few patches that fix build errors or warnings that
>>>> I encountered while doing arc "allmodconfig" builds.
>>>>
>>>> These patches do not fix all of the build issues.
>>>>
>>>>
>>>>  arch/arc/include/asm/delay.h            |    2 ++
>>>>  arch/arc/mm/cache.c                     |   11 ++++++-----
>>>>  arch/arc/plat-eznps/include/plat/ctop.h |    1 +
>>>>  arch/arc/plat-eznps/mtm.c               |    6 ++++--
>>>>  4 files changed, 13 insertions(+), 7 deletions(-)
>>>> <EOF>
>>>>
>>>>
>>>> What am I doing wrong?
>>>
>>> User error (of course).  Missing "series" file.
>>>
>>> Now that I have a series file, I get this error:
>>> Unable to extract a subject header from 001-arc-delay-use-intll64h.patch
>>>
>>> where the first line in that file is:
>>> Subject: arc: fix some build issues in delay.h
>>>
>>> Is there a trick to conjuring quilt into accepting a Subject: line?
>>
>> It should accept that by default. Is 001-arc-delay-use-intll64h.patch
>> located in the patches/ directory, where quilt expects all the patches
>> to be located by default?
>>
>> The following works for me:
>>
>> $ cat patches/series
>> foo.patch
>> $ cat patches/foo.patch
>> Subject: This is foo
>>
>> Index: agruenba/foo
>> ===================================================================
>> --- /dev/null
>> +++ agruenba/foo
>> @@ -0,0 +1 @@
>> +foo
>> $ quilt mail --mbox mbox --subject Test
>
>
> OK, I'm getting closer.  However, using "--subject" seems to be required.
> Is that correct?  If I use "-M intro.txt" without --subject, quilt says:
>
> Introduction has no subject header
>
> even though it looks like this:
> Subject: arc: some allmodconfig fixup patches
> From: Randy Dunlap <address@hidden>
> Cc: address@hidden
>
> Hi,
> <+ more lines>
>
> But when I use --subject <whatever>, it does produce an mbox file for me.

It's complaining about the subject of the cover letter which you can
either provide with --subject or fill in in the editor. That error
could probably be downgraded to a warning though ...

Andreas