[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Rapp-dev] Build fails on OSX
From: |
Hans-Peter Nilsson |
Subject: |
Re: [Rapp-dev] Build fails on OSX |
Date: |
Wed, 16 Feb 2011 01:10:40 +0100 |
> Date: Wed, 15 Dec 2010 23:57:45 +0100
> From: Hans-Peter Nilsson <address@hidden>
> > Date: Wed, 15 Dec 2010 11:10:30 +0100
> > From: Johan Almbladh <address@hidden>
>
> > That fixes it.
>
> Ok, I'll commit that. However, I think this was an
> implementation flaw and that RAPP_API should do it all without
> requiring #include "rapp_whateverinterface.h", i.e. something
> like:
>
> diff --git a/driver/rapp_api.h b/driver/rapp_api.h
> index a928096..cbe556e 100644
> --- a/driver/rapp_api.h
> +++ b/driver/rapp_api.h
> @@ -59,6 +59,7 @@ extern int rc_initialized;
>
> #else
> #define RAPP_API(rtype, name, args) \
> + RAPP_EXPORT rtype name args; \
> rtype name args
>
> #endif
>
> Could you please try this without the other patch?
It has the intended effect. I committed both after testing on a
x86_64-apple-darwin10.6.0 with "gcc version 4.2.1 (Apple
Inc. build 5664)", which exposed an unrelated type-mismatch bug
in the test-suite, also fixed. One issue less.
brgds, H-P
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Rapp-dev] Build fails on OSX,
Hans-Peter Nilsson <=