rapp-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Rapp-dev] Recent changes to escape gcc-4.6 warnings may hide bugs


From: Johan Almbladh
Subject: Re: [Rapp-dev] Recent changes to escape gcc-4.6 warnings may hide bugs
Date: Wed, 21 Mar 2012 09:38:27 +0100

H-P,

Those patches look sane to me.

For the vectorized filter operations, the driver template maintains a running 3x3 vector context that can be used by actual filters. Many filters don't use the full context and we rely on the compiler to optimize out the unused context vectors. However, we need to silence the those unused variable warnings just like you propose.

Best regards,
Johan

On Thu, Mar 15, 2012 at 2:41 PM, Hans-Peter Nilsson <address@hidden> wrote:
I fear those unused variables maybe actually should have been
used and I'm covering up actual thinkos, so please have a look
at commits 9e75df3c293c2609d0484be7bf46420bd0d5fdc2 and
767cf11ea11bf0eb899ccd650bca1478e48fc8c6 to the master branch,
nicely presented for your viewing pleasure at
<http://git.savannah.gnu.org/cgit/rapp.git/commit/?id=9e75df3c293c2609d0484be7bf46420bd0d5fdc2>
and
<http://git.savannah.gnu.org/cgit/rapp.git/commit/?id=767cf11ea11bf0eb899ccd650bca1478e48fc8c6>.

Thanks.

brgds, H-P



reply via email to

[Prev in Thread] Current Thread [Next in Thread]