[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RP] [PATCH] avoid infinite loop after using redo
From: |
Shawn Betts |
Subject: |
Re: [RP] [PATCH] avoid infinite loop after using redo |
Date: |
Wed, 15 Mar 2006 20:17:15 -0500 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (berkeley-unix) |
"Bernhard R. Link" <address@hidden> writes:
> The attached patch fixes two problems together causing
> an infinite loop when quiting ratpoison in some cases:
>
> src/actions.c pop_frame_undo and pop_frame_redo do
> not change the value of rp_num_frame_undos
>
> and
>
> src/main.c clean_up does try to free rp_num_frame_undos
> undo steps, causing an infinite loop if there are not that
> many left.
> (Perhaps better than this patch would be to create something
> actiong like clear_frame_redo and being called from here).
I decided to get rid of the global var and just use list_size. This
means every call will walk the list to calculate the size. Not the
cleanest solution, but the list is generally smallish so I don't think
it matters.
-Shawn