[Rdiff-backup-bugs] [bug #26848] Restoring hardlinked files: "Hash for foo missing, cannot check"

[Joe Steele]

Follow-up Comment #3, bug #26848 (project rdiff-backup):

More problems with hardlinked files...

Since the time of my original bug submission on 6/19/09, I have encountered a
different test case that was not fixed by the original patch that I had
submitted.  New patches are attached for Hardlink.py and compare.py that fix
the problems demonstrated in the following example (patches are against
version 1.2.8).

Create 2 files that are hardlinked to each other, back them up, then move the
'first' file so that it comes after the second file, then back them up again. 
The SHA1 digest is lost (no longer in the mirror metadata).  Errors are
generated when trying to restore the backup, and when verifying the backup,
and when comparing the hash of the backup:

$ mkdir folder
$ touch folder/a
$ link folder/a folder/b
$ rdiff-backup folder backup
$ mv folder/a folder/c
$ sleep 1
$ rdiff-backup folder backup
$ mkdir restore
$ rdiff-backup -r now backup restore
Hash for b missing, cannot check

$ rdiff-backup --verify backup
Warning: Cannot find SHA1 digest for file b,
perhaps because this feature was added in v1.1.1
Warning: Cannot find SHA1 digest for file c,
perhaps because this feature was added in v1.1.1
Every file verified successfully.

$ rdiff-backup --compare-hash folder backup
Warning: Metadata file has no digest for b, unable to compare.
Warning: Metadata file has no digest for c, unable to compare.
No changes found.  Directory matches archive data.

(No doubt bugs #20925 and #27391 are related to the above problems.)

(file #21244, file #21245)
    _______________________________________________________

Additional Item Attachment:

File name: Hardlink.py.revised-patch.txt  Size:0 KB
File name: compare.py.patch.txt           Size:2 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?26848>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/