[rdiff-backup-users] crashes when trying to backup / with AFS running even when excluding /afs

[Carl Chenet]

Hi,

I tried running rdiff-backup under backupninja to do backups on a system
with
OpenAFS running, and found that it crashes trying to list files under /afs even
if I exclude /afs from the backup. The way backupninja calls rdiff-backup is to
run it on /, and include/exclude the relevant directories to be backed up,
like:

/usr/bin/rdiff-backup  --print-statistics --exclude '/home/*/.gnupg' --exclude 
'/home/*/.local/share/Trash' --exclude '/home/*/.Trash' --exclude 
'/home/*/.thumbnails' --exclude '/home/*/.beagle' --exclude '/home/*/.sheep' 
--include '/var/spool/cron/crontabs' --include '/var/backups' --include '/etc' 
--include '/root' --include '/home' --include '/usr/local/*bin' --include 
'/var/lib/dpkg/status*' --exclude '/*' / address@hidden::/srv/backups/test

I can reproduce the crash error by running the following simpler command:

rdiff-backup --exclude '/afs' / test

It seems that rdiff-backup is trying to list files in /afs even when it's
excluded. If I turn off openafs, the backup proceeds as expected. Any thoughts?

I get the following with 1.2.8, so it appears to both be a bug and not fixed
in the latest version:

address@hidden:~/tmp> rdiff-backup --exclude '/afs/**' / test  
ListError afs/.athena.mit.edu/activity/a/a-archives/Nanopunk [Errno 13] 
Permission denied: '/afs/.athena.mit.edu/activity/a/a-archives/Nanopunk'
ListError afs/.athena.mit.edu/activity/a/a-archives/OldFiles/Nanopunk [Errno 
13] Permission denied: 
'/afs/.athena.mit.edu/activity/a/a-archives/OldFiles/Nanopunk'
Exception '[Errno 19] No such device: 
'/afs/.athena.mit.edu/activity/a/a-archives/OldFiles/OldFiles'' raised of class 
'<type 'exceptions.OSError'>':
  File "/usr/lib/pymodules/python2.5/rdiff_backup/robust.py", line 32, in 
check_common_error
    try: return function(*args)
  File "/usr/lib/pymodules/python2.5/rdiff_backup/rpath.py", line 1149, in 
append
    return self.__class__(self.conn, self.base, self.index + (ext,))
  File "/usr/lib/pymodules/python2.5/rdiff_backup/rpath.py", line 884, in 
__init__
    else: self.setdata()
  File "/usr/lib/pymodules/python2.5/rdiff_backup/rpath.py", line 908, in 
setdata
    self.data = self.conn.rpath.make_file_dict(self.path)
  File "/usr/lib/pymodules/python2.5/rdiff_backup/rpath.py", line 287, in 
make_file_dict
    return C.make_file_dict(filename)

Exception '[Errno 19] No such device: 
'/afs/.athena.mit.edu/activity/a/a-archives/OldFiles/OldFiles'' raised of class 
'<type 'exceptions.OSError'>':
  File "/usr/lib/pymodules/python2.5/rdiff_backup/Main.py", line 304, in 
error_check_Main
    try: Main(arglist)
  File "/usr/lib/pymodules/python2.5/rdiff_backup/Main.py", line 324, in Main
    take_action(rps)
  File "/usr/lib/pymodules/python2.5/rdiff_backup/Main.py", line 280, in 
take_action
    elif action == "backup": Backup(rps[0], rps[1])
  File "/usr/lib/pymodules/python2.5/rdiff_backup/Main.py", line 334, in Backup
    rpout.conn.fs_abilities.backup_set_globals(rpin, force)
  File "/usr/lib/pymodules/python2.5/rdiff_backup/fs_abilities.py", line 920, 
in backup_set_globals
    src_fsa = rpin.conn.fs_abilities.get_readonly_fsa('source', rpin)
  File "/usr/lib/pymodules/python2.5/rdiff_backup/fs_abilities.py", line 611, 
in get_readonly_fsa
    return FSAbilities(desc_string).init_readonly(rp)
  File "/usr/lib/pymodules/python2.5/rdiff_backup/fs_abilities.py", line 130, 
in init_readonly
    self.set_resource_fork_readonly(rp)
  File "/usr/lib/pymodules/python2.5/rdiff_backup/fs_abilities.py", line 511, 
in set_resource_fork_readonly
    for rp in selection.Select(dir_rp).set_iter():
  File "/usr/lib/pymodules/python2.5/rdiff_backup/selection.py", line 132, in 
Iterate_fast
    try: rpath, val = diryield_stack[-1].next()
  File "/usr/lib/pymodules/python2.5/rdiff_backup/selection.py", line 120, in 
diryield
    rpath.append, (filename,))
  File "/usr/lib/pymodules/python2.5/rdiff_backup/robust.py", line 32, in 
check_common_error
    try: return function(*args)
  File "/usr/lib/pymodules/python2.5/rdiff_backup/rpath.py", line 1149, in 
append
    return self.__class__(self.conn, self.base, self.index + (ext,))
  File "/usr/lib/pymodules/python2.5/rdiff_backup/rpath.py", line 884, in 
__init__
    else: self.setdata()
  File "/usr/lib/pymodules/python2.5/rdiff_backup/rpath.py", line 908, in 
setdata
    self.data = self.conn.rpath.make_file_dict(self.path)
  File "/usr/lib/pymodules/python2.5/rdiff_backup/rpath.py", line 287, in 
make_file_dict
    return C.make_file_dict(filename)

Traceback (most recent call last):
  File "/usr/bin/rdiff-backup", line 30, in <module>
    rdiff_backup.Main.error_check_Main(sys.argv[1:])
  File "/usr/lib/pymodules/python2.5/rdiff_backup/Main.py", line 304, in 
error_check_Main
    try: Main(arglist)
  File "/usr/lib/pymodules/python2.5/rdiff_backup/Main.py", line 324, in Main
    take_action(rps)
  File "/usr/lib/pymodules/python2.5/rdiff_backup/Main.py", line 280, in 
take_action
    elif action == "backup": Backup(rps[0], rps[1])
  File "/usr/lib/pymodules/python2.5/rdiff_backup/Main.py", line 334, in Backup
    rpout.conn.fs_abilities.backup_set_globals(rpin, force)
  File "/usr/lib/pymodules/python2.5/rdiff_backup/fs_abilities.py", line 920, 
in backup_set_globals
    src_fsa = rpin.conn.fs_abilities.get_readonly_fsa('source', rpin)
  File "/usr/lib/pymodules/python2.5/rdiff_backup/fs_abilities.py", line 611, 
in get_readonly_fsa
    return FSAbilities(desc_string).init_readonly(rp)
  File "/usr/lib/pymodules/python2.5/rdiff_backup/fs_abilities.py", line 130, 
in init_readonly
    self.set_resource_fork_readonly(rp)
  File "/usr/lib/pymodules/python2.5/rdiff_backup/fs_abilities.py", line 511, 
in set_resource_fork_readonly
    for rp in selection.Select(dir_rp).set_iter():
  File "/usr/lib/pymodules/python2.5/rdiff_backup/selection.py", line 132, in 
Iterate_fast
    try: rpath, val = diryield_stack[-1].next()
  File "/usr/lib/pymodules/python2.5/rdiff_backup/selection.py", line 120, in 
diryield
    rpath.append, (filename,))
  File "/usr/lib/pymodules/python2.5/rdiff_backup/robust.py", line 32, in 
check_common_error
    try: return function(*args)
  File "/usr/lib/pymodules/python2.5/rdiff_backup/rpath.py", line 1149, in 
append
    return self.__class__(self.conn, self.base, self.index + (ext,))
  File "/usr/lib/pymodules/python2.5/rdiff_backup/rpath.py", line 884, in 
__init__
    else: self.setdata()
  File "/usr/lib/pymodules/python2.5/rdiff_backup/rpath.py", line 908, in 
setdata
    self.data = self.conn.rpath.make_file_dict(self.path)
  File "/usr/lib/pymodules/python2.5/rdiff_backup/rpath.py", line 287, in 
make_file_dict
    return C.make_file_dict(filename)
OSError: [Errno 19] No such device: 
'/afs/.athena.mit.edu/activity/a/a-archives/OldFiles/OldFiles'

Bug report by: Christine Spang <address@hidden>
Bug report : http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=508063

Bye,
-- 
Carl Chenet