screen-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [screen-devel] [PATCH] Stuff without parameters gives Input prompt


From: Sadrul Habib Chowdhury
Subject: Re: [screen-devel] [PATCH] Stuff without parameters gives Input prompt
Date: Sun, 14 Sep 2008 04:23:03 -0400
User-agent: Mutt/1.5.16 (2007-06-11)

* Dick had this to say on [06 Aug 2008, 19:14:24 +0200]:
> Hi all,

Hi. Thanks for your patch. It has been applied to the development tree,
and should be included in the next release (commit a6cb77 [1]).

> Please review this patch, I'm missing something. I can't bind stuff to
> (i.e. s). When I try to "bind s stuff" screen freezes.

The commit includes a fix for this.

> This feature is usefull when using a very slow remote shell session (SSH
> over a bad GPRS connection). By locally preparing a command you can
> enter a command and send it as bulk (without typos ;-)).
> 
> And, it might be handy to support the (undocumented) -k parameter
> without parameter. I haven't added it yet.

Given what -k does, I don't think that will be necessary.

> --- screen-4.0.2.orig/process.c       2003-09-18 14:53:54.000000000 +0200
> +++ screen-4.0.2/process.c    2008-08-06 18:07:58.000000000 +0200

[snip]
> +      if (!args[0])
> +        {
> +          Input("Stuff:", 7, INP_COOKED, StuffFin, NULL);

I have changed to allow inputs of length upto 100 (which is the maximum
allowed). Was there a reason you limited it to only 7?

Cheers,
Sadrul

[1] 
http://git.savannah.gnu.org/gitweb/?p=screen.git;a=commit;h=a6cb77fd232318a363f951ec54b822445810595f




reply via email to

[Prev in Thread] Current Thread [Next in Thread]