[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[screen-devel] Patch fixing warnings (-Wwrite-string, -pedantic)
From: |
Tim Ruehsen |
Subject: |
[screen-devel] Patch fixing warnings (-Wwrite-string, -pedantic) |
Date: |
Mon, 27 Feb 2012 10:46:05 +0100 |
User-agent: |
KMail/1.13.7 (Linux/3.2.0-1-amd64; KDE/4.6.5; x86_64; ; ) |
Attached is a bigger patch regarding
* Fixed warnings for gcc's -Wwrite-string and -pedantic
* Fixed endless loop in acls.c/UsersAcl()
* screenterm[] resized from 20 to 64 bytes
* Removed C99 // comments
* Removed C99 mixed declarations and code
The project is looking for contributors.
IMHO, the project would be more attractive to programmers, if the source would
be polished to newer standards.
Currently some parts (e.g. function prototypes/definitions, having ) are still
pre-C89 K&R standards, e.g. function prototypes/definitions, using InStr()
instead of strstr(), index()/rindex() [LEGACY since POSIX.1-2001] instead of
strchr()/strrchr().
There is some code that conforms to C99 (e.g. unconditionally use of
snprintf() in process.c and screen.c). [Uh, one of my customers still runs a
SCO system without snprintf() available - but he did not update any system
software since ~15 years, and he will never do.]
Why not just saying, screen needs
* a C89 compliant compiler+library
* snprintf() available (currently assumed anyway)
* _POSIX_C_SOURCE >= 200112L
* more ...
I am the first volunteer to work on that.
screen2.diff
Description: Text Data
- [screen-devel] Patch fixing warnings (-Wwrite-string, -pedantic),
Tim Ruehsen <=