[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[screen-devel] [Trivial] Bugfixes and compiler warnings
From: |
Kieran Bingham |
Subject: |
[screen-devel] [Trivial] Bugfixes and compiler warnings |
Date: |
Sun, 4 Oct 2015 16:52:25 +0100 |
This patch set cleans up a set of compiler warnings, and issues.
Specifially, there was an unsigned comparison against < 0 which
would have never evaluated true.
The out of tree build has been fixed by using the -iquote CPP parameter
so that it will correctly only include the local "config.h", and
not override any system headers (such as pty.h...)
These commits are mostly related to signedness issues, and whilst
I have tried to read and verify the surrounding code to ensure I am
performing the correct fix (as opposed to the obvious fix), they should
still be reviewed before applying.
This patch set compiles cleanly with -Wno-unused-result -Wno-unused-parameter
but does not tackle those issues yet. That set of warnings is for another
day (or another person)
I am a big fan of using -Werror to prevent warnings creeping back in, but
I'll leave that as a decision for the maintainer :D
This patch set will be mirrored/hosted at github at the following tag:
https://github.com/kbingham/screen/tree/2015_10_04_bug_fixes_v1
Please review and feel free to make adjustments if required, or let me
known and I'll re-spin the patch set.
--
Regards
Kieran
- [screen-devel] [Trivial] Bugfixes and compiler warnings,
Kieran Bingham <=
- [screen-devel] [PATCH 1/8] Makefile.in: Fix out of tree build, Kieran Bingham, 2015/10/08
- [screen-devel] [PATCH 2/8] Process: Fix sign-compare errors, Kieran Bingham, 2015/10/08
- [screen-devel] [PATCH 3/8] Process: Fix const qualifer loss in ShowWindows, Kieran Bingham, 2015/10/08
- [screen-devel] [PATCH 5/8] Process: Fix printf modifier warning, Kieran Bingham, 2015/10/08
- [screen-devel] [PATCH 6/8] Display: Unsigned comparison causes unreachable code, Kieran Bingham, 2015/10/08
- [screen-devel] [PATCH 4/8] Process: Pointer arithmetic comparison with unsigned size_t, Kieran Bingham, 2015/10/08
- [screen-devel] [PATCH 7/8] Display: Convert strlen_onscreen to be unsigned like strlen, Kieran Bingham, 2015/10/08
- [screen-devel] [PATCH 8/8] WinMsgBuf: Fix const qualifier in wmbc_mergewmb, Kieran Bingham, 2015/10/08