simulavr-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Simulavr-devel] [PATCH] use static callbacks instead of template pa


From: panic
Subject: Re: [Simulavr-devel] [PATCH] use static callbacks instead of template param for IOReg
Date: Fri, 16 Jun 2017 23:08:00 +0000

Hi,

panic:
> - makes registers in the IO memory space children of
>   BitAccessibleRegister (e.g. GPIORegister, CPKPRRegister)
>   for new hierarchy, see attached PNG.

Regarding this I like to note that I also don't like this approach of
having some other registers (GPIO, CLKPR, ...) being subclasses of
IOReg/BitAccessibleRegister. IMO, they are peripherals (subclass of
Hardware only) and should have a IOReg as a member.
IOReg or even RWMemoryMember should also contain the value of the
peripheral -- avoiding the current duplication of a unsigned char in the
peripheral and the IOReg member (e.g. class HWPort: ddr and ddr_reg).
But this is another patch...



reply via email to

[Prev in Thread] Current Thread [Next in Thread]