[Simulavr-devel] [BUG] [PATCH] Typo and Tracing

[panic]

Hi all,

there are two other bugs. Simple fixes pasted below:

(1/2) An error message uses the wrong method name, (copy&paste error)

> diff --git a/src/specialmem.cpp b/src/specialmem.cpp
> index b3411eb..cf486a8 100644
> --- a/src/specialmem.cpp
> +++ b/src/specialmem.cpp
> @@ -61,7 +61,7 @@ RWReadFromFile::RWReadFromFile(TraceValueRegister *registry,
>  }
>  
>  void RWReadFromFile::set(unsigned char val) {
> -    avr_warning("Invalid write access to RWWriteToFile register with value 
> %d.", (int)val);
> +    avr_warning("Invalid write access to RWReadFromFile register with value 
> %d.", (int)val);
>  }
>  
>  unsigned char RWReadFromFile::get() const { 

(2/2) Traces of IOSpecialReg (e.g. EIMSK) are not correctly updated.

> diff --git a/src/rwmem.cpp b/src/rwmem.cpp
> index 9424a9a..7b27a05 100644
> --- a/src/rwmem.cpp
> +++ b/src/rwmem.cpp
> @@ -264,6 +271,7 @@ void IOSpecialReg::set(unsigned char val) {
>      for(size_t i = 0; i < clients.size(); i++)
>          val = clients[i]->set_from_reg(this, val);
>      value = val;
> +    hardwareChange(value);
>  }
>  

Cheers,
panic