Re: [Solang-devel] [PATCH] Search infrastructure

[Santanu Sinha]

Updated, attached.

----
Upset the established order, and everything becomes chaos. I'm an
agent of chaos. Oh and you know the thing about chaos, it's fair.



On Sat, May 23, 2009 at 6:46 PM, Debarshi Ray <address@hidden> wrote:
> (CC'ing solang-devel)
>
>> final patch.
>
> It does not apply against the latest Git tree in Savannah. Are there
> some other intermediate patches?
>
> ~~~~
> diff --git a/src/attribute/search-basket.cpp b/src/attribute/search-basket.cpp
> index 1086586..fa0907a 100644
> --- a/src/attribute/search-basket.cpp
> +++ b/src/attribute/search-basket.cpp
> @@ -32,16 +33,26 @@
>  namespace Solang
>  {
>
> -SearchBasket::SearchBasket() throw() :
> +SearchBasket::SearchBasket(ApplicationPtr application) throw() :
> [...]
> +    application_( application )
> ~~~~
>
> The idea was to keep the constructors and destructors independent from
> the application and do the hand-shaking in the init and final methods
> which are passed a reference to the application. eg., see
> src/attribute/tag-manager.cpp
>
>
> ~~~~
> diff --git a/src/attribute/tag-manager.cpp b/src/attribute/tag-manager.cpp
> index 5605695..3884698 100644
> --- a/src/attribute/tag-manager.cpp
> +++ b/src/attribute/tag-manager.cpp
> @@ -47,10 +47,7 @@ TagManager::TagManager() throw() :
> -    tagView_()
> +    tagView_( application_ )
>  {
>     Gtk::IconSource icon_source;
> ~~~~
>
> application_ is 0, so tagView will also be 0.
>
> ~~~~
> @@ -164,9 +148,8 @@ TagManager::init(Application & application)
>     throw()
>  {
>     application_ = &application;
> +    tagView_.set_application( application_ );
> ~~~~
>
> Might be a good idea to use '&application' instead of 'application_'
> in init and final, because that way it will be easier to notice when
> application_ becomes unnecessary.
>
> ~~~~
> diff --git a/src/attribute/search-basket.h b/src/attribute/search-basket.h
> index 60d00ce..074c351 100644
> --- a/src/attribute/search-basket.h
> +++ b/src/attribute/search-basket.h
> +        Gtk::Button clearButton_;
> +               Gtk::Image  clearImage_;
> +
> +        Gtk::Button trashButton_;
> +               Gtk::Image  trashImage_;
> +
>         Gtk::ScrolledWindow scrolledWindow_;
> ~~~~
>
> Tabs.
>
> ~~~~
> diff --git a/src/common/types.h b/src/common/types.h
> index b741441..59a3777 100644
> --- a/src/common/types.h
> +++ b/src/common/types.h
> @@ -26,6 +26,8 @@
>  #include <glibmm.h>
>  #include <gtkmm.h>
>  #include <libgdamm.h>
> +#include <map>
> +#include <vector>
> ~~~~
>
> Might be good to put them above '#include <glibmm.h>'.
>
> --
> One reason that life is complex is that it has a real part and an
> imaginary part.
>    -- Andrew Koenig
>

0001-Implementation-of-searching-functionality-using-bask.patch
Description: Text Data