Re: [STUMP] Intuitive Resize Patch

[Scott Jaderholm]

Burton,

Thanks, I do find your resizing behavior to be much more intuitive.

I think your patch introduces two style warnings, the first one seems
to be serious.

; file: /home/scott/src/stumpwm/iresize.lisp
; in: DEFUN SET-RESIZE-INCREMENT
;     (STUMPWM::UPDATE-RESIZE-MAP)
;
; caught STYLE-WARNING:
;   The function was called with zero arguments, but wants exactly six.

; in: DEFCOMMAND (IRESIZE TILE-GROUP)
;     (LET* ((STUMPWM::GROUP (STUMPWM:CURRENT-GROUP))
;            (STUMPWM::FRAME (STUMPWM::TILE-GROUP-CURRENT-FRAME STUMPWM::GROUP))
;            (STUMPWM::HEAD-FRAME
;             (STUMPWM::FRAME-HEAD STUMPWM::GROUP
;                                  (STUMPWM::TILE-GROUP-CURRENT-FRAME
;                                   STUMPWM::GROUP)))
;            (STUMPWM::DX (STUMPWM::FRAME-X STUMPWM::HEAD-FRAME))
;            (STUMPWM::DH (STUMPWM::FRAME-HEIGHT STUMPWM::HEAD-FRAME))
;            (STUMPWM::DW (STUMPWM::FRAME-WIDTH STUMPWM::HEAD-FRAME))
;            (STUMPWM::FX (- (STUMPWM::FRAME-X STUMPWM::FRAME) STUMPWM::DX))
;            (STUMPWM::FY (STUMPWM::FRAME-Y STUMPWM::FRAME))
;            (STUMPWM::FH (STUMPWM::FRAME-HEIGHT STUMPWM::FRAME))
;            (STUMPWM::FW (STUMPWM::FRAME-WIDTH STUMPWM::FRAME)))
;       (IF (ATOM
;            (STUMPWM::TILE-GROUP-FRAME-HEAD STUMPWM::GROUP
;                                            (STUMPWM::FRAME-HEAD STUMPWM::GROUP
;
STUMPWM::FRAME)))
;           (STUMPWM:MESSAGE "There's only 1 frame!")
;           (PROGN
;            (WHEN STUMPWM:*RESIZE-HIDES-WINDOWS* (DOLIST # #))
;            (STUMPWM:MESSAGE "Resize Frame")
;            (STUMPWM::UPDATE-RESIZE-MAP STUMPWM::FX STUMPWM::FY STUMPWM::FH
;                                        STUMPWM::FW STUMPWM::DH STUMPWM::FW)
;            (STUMPWM::PUSH-TOP-MAP STUMPWM:*RESIZE-MAP*)
;            (STUMPWM::DRAW-FRAME-OUTLINES STUMPWM::GROUP
(STUMPWM:CURRENT-HEAD)))))
;
; caught STYLE-WARNING:
;   The variable DW is defined but never used.


Scott


On Thu, Aug 16, 2012 at 8:42 PM, Burton Samograd
<address@hidden> wrote:
> Hello,
>
> I've always found that stumpwm's interactive frame resize was a bit 
> un-intuative with respect to the position of windows and how they are 
> resized.  This patch helps alleviate this by changing the idea of resizing 
> frames to moving the divider between the adjacent frames.
>
> Windows are resized now based on their position in the head frame: either 
> touching the left edge or touching the right edge.  Windows in the middle are 
> assumed to be touching the left edge.  Windows on the left edge get larger 
> horizontally when pressing C-f and smaller using C-b; windows on the right 
> edge are the opposite. An identical strategy is used for vertical resizing.
>
> This has been tested on a 2 monitor setup and works as expected.
>
> Attached is a patch to implement this behaviour and hopefully people find it 
> useful and a better resizing experience.  I know I do :)
>
> --
> Burton Samograd
>
> _______________________________________________
> Stumpwm-devel mailing list
> address@hidden
> https://lists.nongnu.org/mailman/listinfo/stumpwm-devel
>