[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Swftools-common] [PATCH] swfrender command-line interface enhanceme
From: |
Chris |
Subject: |
Re: [Swftools-common] [PATCH] swfrender command-line interface enhancement |
Date: |
Wed, 2 May 2012 02:20:28 -0100 |
Thank you for your contrubution Sergey. My humble eyes see nothing wrong with
your submission. ;o)
Patches sent to this list are usually reviewed by Matthias, then if deemed
appropriate, implemented in the current git version.
Regards,
Chris.
>On Tue, 1 May 2012 13:40:18 +0300
>Sergey Vinokurov <address@hidden> wrote:
> Hello, I'm not sure how one properly proposes enhancements, but when
> using swfrender program it took me a while to figure out command-line
> parameters to set dimensions of resulting image simply because they were
> not mentioned in usage snippet. So I decided to add them to usage and
> here's the patch.
>
> And please tell me if I'm doing something wrong.
>
> --
> diff --git a/src/swfrender.c b/src/swfrender.c
> index 87a8b32..f6e55aa 100644
> --- a/src/swfrender.c
> +++ b/src/swfrender.c
> @@ -93,11 +93,13 @@ int args_callback_longoption(char*name,char*val)
> void args_callback_usage(char *name)
> {
> printf("\n");
> - printf("Usage: %s file.swf [-o output.png]\n", name);
> + printf("Usage: %s file.swf [-X<width>] [-Y<height>] [-o
> output.png]\n", name);
> printf("\n");
> printf("-h , --help Print short help message
> and exit\n");
> printf("-l , --legacy Use old rendering framework\n");
> - printf("-o , --output Output file (default:
> output.png)\n");
> + printf("-o , --output Output file (default:
> output.png)\n");
> + printf("-X Width of resulting image\n");
> + printf("-Y Height of resulting image\n");
> printf("\n");
> }
> int args_callback_command(char*name,char*val)
> --
>
> ---------------
> SWFTools-common is a self-managed list. To subscribe/unsubscribe, or amend an
> existing subscription, please kindly point your favourite web browser
> at:<http://lists.nongnu.org/mailman/listinfo/swftools-common>