texinfo-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

texinfo/tp texi2any.pl


From: Patrice Dumas
Subject: texinfo/tp texi2any.pl
Date: Wed, 02 Nov 2011 00:42:13 +0000

CVSROOT:        /sources/texinfo
Module name:    texinfo
Changes by:     Patrice Dumas <pertusus>        11/11/02 00:42:13

Modified files:
        tp             : texi2any.pl 

Log message:
        Rewrite some of the FIXME and remove the obsolete ones.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/texinfo/tp/texi2any.pl?cvsroot=texinfo&r1=1.80&r2=1.81

Patches:
Index: texi2any.pl
===================================================================
RCS file: /sources/texinfo/texinfo/tp/texi2any.pl,v
retrieving revision 1.80
retrieving revision 1.81
diff -u -b -r1.80 -r1.81
--- texi2any.pl 1 Nov 2011 12:01:21 -0000       1.80
+++ texi2any.pl 2 Nov 2011 00:42:13 -0000       1.81
@@ -281,7 +281,9 @@
   return 1;
 }
 
-# FIXME also get @-command results?
+# This also could get and set some @-command results.
+# FIXME But it does not take into account what happens during conversion,
+# for that something like $converter->get_conf(...) has to be used.
 sub get_conf($) {
   my $var = shift;
   if (exists($cmdline_options->{$var})) {
@@ -424,8 +426,6 @@
 
 sub _set_variables_texi2html()
 {
-  # FIXME all that are set to 0 could be negated, in order to have the default
-  # (undef) right.
   my @texi2html_options = (
   ['NO_USE_SETFILENAME', 1],
   ['USE_SETFILENAME_EXTENSION', 0],
@@ -678,7 +678,6 @@
       $parser_default_options->{'novalidate'} = $_[1];
     },
  'no-warn' => sub { set_from_cmdline('NO_WARN', $_[1]); },
- # FIXME pass to parser? What could it mean in parser?
  'verbose|v!' => sub {set_from_cmdline('VERBOSE', $_[1]); 
                      push @texi2dvi_args, '--verbose'; },
  'document-language=s' => sub {
@@ -1020,8 +1019,9 @@
       and $formats_table{$format}->{'internal_links'}) {
     my $internal_links_text 
       = $converter->output_internal_links();
-    # FIXME output only if there are links or always, maybe creating an 
-    # empty file.
+    # FIXME(Karl) it is possible to output only if there are links, or always, 
+    # maybe creating an empty file.  Right now it is only output if there
+    # is something to output
     if (defined($internal_links_text)) {
       my $internal_links_file = get_conf('INTERNAL_LINKS');
       my $internal_links_fh = Texinfo::Common::open_out($converter, 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]