branch master updated: Fix unnumbered sections in PDF outline.

[Gavin D. Smith]

This is an automated email from the git hooks/post-receive script.

gavin pushed a commit to branch master
in repository texinfo.

The following commit(s) were added to refs/heads/master by this push:
     new 8bd3af0c4a Fix unnumbered sections in PDF outline.
8bd3af0c4a is described below

commit 8bd3af0c4ad4e88e63c4c6a28e660721805a6905
Author: Gavin Smith <gavinsmith0123@gmail.com>
AuthorDate: Fri Feb 9 22:07:28 2024 +0000

    Fix unnumbered sections in PDF outline.
    
    * doc/texinfo.tex (\unnumbered, \unnumberedsec, \unnumberedsubsec)
    (\unnumberedsubsubsec): Only increment \unnumberedno, not \secno,
    \subsecno or \subsubsecno.  Only place \unnumberedno in the auxiliary
    .toc file.  There was a bug where the section identifier might
    not be unique due to \unnumberedno only being incremented for the
    top-level @unnumbered command, not for any of the lower levels.
    For example, if two @chapter's had an @unnumberedsec in position
    8 in the chapter, the identifier 10001.8 would occur twice.  PDF
    readers such as evince had trouble making sense of the ensuing
    PDF "outline".
    
    Report from Arnold Robbins.
---
 ChangeLog       | 17 +++++++++++++++++
 doc/texinfo.tex | 21 +++++++++------------
 2 files changed, 26 insertions(+), 12 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index aa8f91ff29..a24640cc8d 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,20 @@
+2024-02-09  Gavin Smith <gavinsmith0123@gmail.com>
+
+       Fix unnumbered sections in PDF outline.
+
+       * doc/texinfo.tex (\unnumbered, \unnumberedsec, \unnumberedsubsec)
+       (\unnumberedsubsubsec): Only increment \unnumberedno, not \secno,
+       \subsecno or \subsubsecno.  Only place \unnumberedno in the auxiliary
+       .toc file.  There was a bug where the section identifier might
+       not be unique due to \unnumberedno only being incremented for the
+       top-level @unnumbered command, not for any of the lower levels.
+       For example, if two @chapter's had an @unnumberedsec in position
+       8 in the chapter, the identifier 10001.8 would occur twice.  PDF
+       readers such as evince had trouble making sense of the ensuing
+       PDF "outline".
+
+       Report from Arnold Robbins.
+
 2024-02-09  Patrice Dumas  <pertusus@free.fr>
 
        * tp/Texinfo/Document.pm (indices_sort_strings), tp/Texinfo/Indices.pm
diff --git a/doc/texinfo.tex b/doc/texinfo.tex
index bd8668c490..fb8e292d53 100644
--- a/doc/texinfo.tex
+++ b/doc/texinfo.tex
@@ -3,9 +3,9 @@
 % Load plain if necessary, i.e., if running under initex.
 \expandafter\ifx\csname fmtname\endcsname\relax\input plain\fi
 %
-\def\texinfoversion{2023-10-19.19}
+\def\texinfoversion{2024-02-09.21}
 %
-% Copyright 1985, 1986, 1988, 1990-2023 Free Software Foundation, Inc.
+% Copyright 1985, 1986, 1988, 1990-2024 Free Software Foundation, Inc.
 %
 % This texinfo.tex file is free software: you can redistribute it and/or
 % modify it under the terms of the GNU General Public License as
@@ -6137,8 +6137,7 @@ might help (with 'rm \jobname.?? \jobname.??s')%
 % normally unnmhead0 calls unnumberedzzz:
 \outer\parseargdef\unnumbered{\unnmhead0{#1}}
 \def\unnumberedzzz#1{%
-  \global\secno=0 \global\subsecno=0 \global\subsubsecno=0
-    \global\advance\unnumberedno by 1
+  \global\advance\unnumberedno by 1
   %
   % Since an unnumbered has no number, no prefix for figures.
   \global\let\chaplevelprefix = \empty
@@ -6194,8 +6193,8 @@ might help (with 'rm \jobname.?? \jobname.??s')%
 % normally calls unnumberedseczzz:
 \outer\parseargdef\unnumberedsec{\unnmhead1{#1}}
 \def\unnumberedseczzz#1{%
-  \global\subsecno=0 \global\subsubsecno=0  \global\advance\secno by 1
-  \sectionheading{#1}{sec}{Ynothing}{\the\unnumberedno.\the\secno}%
+  \global\advance\unnumberedno by 1
+  \sectionheading{#1}{sec}{Ynothing}{\the\unnumberedno}%
 }
 
 % Subsections.
@@ -6218,9 +6217,8 @@ might help (with 'rm \jobname.?? \jobname.??s')%
 % normally calls unnumberedsubseczzz:
 \outer\parseargdef\unnumberedsubsec{\unnmhead2{#1}}
 \def\unnumberedsubseczzz#1{%
-  \global\subsubsecno=0  \global\advance\subsecno by 1
-  \sectionheading{#1}{subsec}{Ynothing}%
-                 {\the\unnumberedno.\the\secno.\the\subsecno}%
+  \global\advance\unnumberedno by 1
+  \sectionheading{#1}{subsec}{Ynothing}{\the\unnumberedno}%
 }
 
 % Subsubsections.
@@ -6244,9 +6242,8 @@ might help (with 'rm \jobname.?? \jobname.??s')%
 % normally unnumberedsubsubseczzz:
 \outer\parseargdef\unnumberedsubsubsec{\unnmhead3{#1}}
 \def\unnumberedsubsubseczzz#1{%
-  \global\advance\subsubsecno by 1
-  \sectionheading{#1}{subsubsec}{Ynothing}%
-                 {\the\unnumberedno.\the\secno.\the\subsecno.\the\subsubsecno}%
+  \global\advance\unnumberedno by 1
+  \sectionheading{#1}{subsubsec}{Ynothing}{\the\unnumberedno}%
 }
 
 % These macros control what the section commands do, according