texinfo-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

branch master updated: * tp/Texinfo/XS/main/manipulate_indices.c: remove


From: Patrice Dumas
Subject: branch master updated: * tp/Texinfo/XS/main/manipulate_indices.c: remove TODO, replace FIXME by TODO.
Date: Mon, 12 Feb 2024 18:43:24 -0500

This is an automated email from the git hooks/post-receive script.

pertusus pushed a commit to branch master
in repository texinfo.

The following commit(s) were added to refs/heads/master by this push:
     new 1fd535d69f * tp/Texinfo/XS/main/manipulate_indices.c: remove TODO, 
replace FIXME by TODO.
1fd535d69f is described below

commit 1fd535d69f1f94125d8ae4a1dc6894fdb1873c50
Author: Patrice Dumas <pertusus@free.fr>
AuthorDate: Tue Feb 13 00:43:20 2024 +0100

    * tp/Texinfo/XS/main/manipulate_indices.c: remove TODO, replace FIXME
    by TODO.
---
 ChangeLog                               |  5 +++++
 tp/Texinfo/XS/main/get_perl_info.c      |  1 +
 tp/Texinfo/XS/main/manipulate_indices.c | 13 +++++--------
 3 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 90a1aa48e3..a73767b93b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2024-02-12  Patrice Dumas  <pertusus@free.fr>
+
+       * tp/Texinfo/XS/main/manipulate_indices.c: remove TODO, replace FIXME
+       by TODO.
+
 2024-02-12  Patrice Dumas  <pertusus@free.fr>
 
        * tp/Texinfo/Document.pm (indices_sort_strings),
diff --git a/tp/Texinfo/XS/main/get_perl_info.c 
b/tp/Texinfo/XS/main/get_perl_info.c
index e9258410e0..6d722e38e0 100644
--- a/tp/Texinfo/XS/main/get_perl_info.c
+++ b/tp/Texinfo/XS/main/get_perl_info.c
@@ -678,6 +678,7 @@ find_index_entry_sv (const SV *index_entry_sv, INDEX 
**index_names,
    in the data structure.  Not clear that it is useful or not, not enabled
    for now */
 /* return value to be freed by caller */
+/* Currently not used */
 INDEX_SORTED_BY_LETTER *
 get_sv_index_entries_sorted_by_letter (INDEX **index_names,
                                        SV *index_entries_sorted_by_letter)
diff --git a/tp/Texinfo/XS/main/manipulate_indices.c 
b/tp/Texinfo/XS/main/manipulate_indices.c
index 63a7c02145..2b5ef5a86a 100644
--- a/tp/Texinfo/XS/main/manipulate_indices.c
+++ b/tp/Texinfo/XS/main/manipulate_indices.c
@@ -573,7 +573,7 @@ setup_collator (int use_unicode_collation, const char 
*collation_language,
   if (use_unicode_collation == 0)
     {
       result->type = ctn_no_unicode;
-      /* FIXME check if needed */
+      /* TODO check if needed */
       result->language = strdup ("");
     }
   else if (collation_language)
@@ -602,7 +602,7 @@ setup_collator (int use_unicode_collation, const char 
*collation_language,
       #endif
 
       result->type = ctn_unicode;
-      /* FIXME check if needed */
+      /* TODO check if needed */
       result->language = strdup ("-");
       result->sv = call_setup_collator (1, 0);
     }
@@ -665,10 +665,9 @@ setup_sortable_index_entries (INDEX_COLLATOR *collator,
                     = &sortable_entry->sortable_subentries[k];
                   INDEX_SUBENTRY_SORT_STRING *subenty_sort_string
                     = &index_entry_sort_string->sort_string_subentries[k];
-              /*    if (subenty_sort_string->sort_string) */
-                    sortable_subentry->sort_string
-                     /* FIXME or refer to subenty_sort_string structure? */
-                     = strdup (subenty_sort_string->sort_string);
+                  /* TODO or refer to subenty_sort_string structure? */
+                  sortable_subentry->sort_string
+                    = strdup (subenty_sort_string->sort_string);
                   sortable_subentry->alpha = subenty_sort_string->alpha;
                   sortable_subentry->sort_key = get_sort_key (collator,
                                            subenty_sort_string->sort_string);
@@ -1090,12 +1089,10 @@ sort_indices_by_letter (ERROR_MESSAGE_LIST 
*error_messages,
                     = letter_sortable_entries->sortable_entries[k]->entry;
                 }
 
-              /* TODO should we reuse the letters instead? */
               free (letter_sortable_entries->letter_sort_key->bytes);
               free (letter_sortable_entries->letter_sort_key);
               free (letter_sortable_entries->sortable_entries);
             }
-          /* TODO should we reuse the letters instead? */
           index_letters_sortable_entries.letter_number = 0;
         }
       index_nr++;



reply via email to

[Prev in Thread] Current Thread [Next in Thread]