[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Texmacs-dev] Re: Probably a wrong condition in src/Typeset/Boxes/Animat
From: |
Henri Lesourd |
Subject: |
[Texmacs-dev] Re: Probably a wrong condition in src/Typeset/Boxes/Animate/animate_boxes.cpp |
Date: |
Tue, 20 Feb 2007 14:32:27 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030821 |
Michal 'vorner' Vaner wrote:
Hello,
There is a very oddly looking condition in
src/Typeset/Boxes/Animate/animate_boxes.cpp
on line 475:
if (t != 1.0 || end_x != x1 != end_y != y1)
The compiler should take the second part like
((end_x != x1) != end_y) != y1
Which probably is not what the author meant. I have 2 ideas of what he
could mean, the first more probable:
end_x != x1 || end_y != y1 //at last one of x and y differs
(end_x != x1) != (end_y != y1) //both or none differ
Could you please tell me, if any of my guess is right? Thank you.
Very probably, it should be a list of conditions separated by '||' :
<<
void set_clipping (ps_device& dev, double t) {
if (t != 1.0 || end_x != x1 || end_y != y1)
dev->extra_clipping (x1, y1, x2, y2); }
>>
, all the more because in the other set_clipping() method, one can
observe precisely this kind of condition :
<<
void set_clipping (ps_device& dev, double t) {
.......
if (t != 1.0 || X1 != x1 || Y1 != y1 || X2 != x2 || Y2 != y2)
dev->extra_clipping (X1, Y1, X2, Y2); }
>>
But I'm not sure. You should try to send a patch to clarify this issue.
- [Texmacs-dev] Re: Probably a wrong condition in src/Typeset/Boxes/Animate/animate_boxes.cpp,
Henri Lesourd <=