Re: [Tiger-devel] [PATCH] Define MESG for HP-UX and fix /etc/ftpusers check

[Ryan Bradetich]

On Thu, 2003-06-26 at 02:25, Javier Fernandez-Sanguino wrote:

> In which system? It does produce the desired results on Linux. From the 
> test manpage:
> 
> "       [-n] STRING# ./scripts/check_root
>                the length of STRING is nonzero"
> 

The man page for HP-UX 11.11 does not indicate the -n is optional :(

        -n s1          True if the length of the string s1 is non-zero.


Here is the results before the change (i.e. how I found the error).
        
# ./scripts/check_root
Configuring...
  
Will try to check using config for '9000/800' running HPUX B.11.11...
--CONFIG-- [con005c] No configuration files for HPUX B.11.11.  Using
           configuration files for generic HPUX.
           Not all checks may be performed.
 
# Performing common access checks for root...
--WARN-- [root002w] Remote root access allowed in /etc/ftpusers
 
# grep root /etc/ftpusers
root

# grep ftpusers ./scripts/check_root
if [ -f /etc/ftpusers ]; then
  if [ "`$GREP '^root$' /etc/ftpusers`" ]; then
     message WARN root002w "" "Remote root access allowed in
/etc/ftpusers"


You are right, it did work properly under Linux, I just restested.

> Your patch really does not change the behavior in Linux but probably 
> works ok in HP-UX and Solaris better, I will make changes in all the 
> file to change the -n implicit behavior and add either -n or -z (if ! 
> was being used).

Thanks much!  I will try to grab a the current source tree from savannah
and start generating diffs against that tree instead of my local tree. 
I have registered as a developer and submitted my SSH1 key, so hopefully
it will work.

This will also be a good double check to verify I have sent all my
patches to you also :)

Thanks much!

- Ryan