Re: [Tinycc-devel] Several patchs from Debian packaging

[RoboTux]

Le mardi 20 avril 2010 21:16:52, grischka a écrit :
> RoboTux wrote:
> > I also changed the load/save_buffer_state horrible hack into a dynarray
> > approach. Take a look at the code, I'm sure you'll be happy with it.
> 
> Yes, happy!
> 
> I guess these 6 lines:
>      file_name = tcc_malloc(sizeof(char) * (strlen(filename) + 1));
>      strcpy(file_name, filename);
>      dynarray_add((void ***) &libs, &nblibs, file_name);
>      lib_name = tcc_malloc(sizeof(char) * (strlen(libname) + 1));
>      strcpy(lib_name, libname);
>      dynarray_add((void ***) &libs, &nblibs, lib_name);
> 
> are logically equal to these 2 lines:
>      dynarray_add((void ***) &libs, &nblibs, tcc_strdup(filename));
>      dynarray_add((void ***) &libs, &nblibs, tcc_strdup(libname));
> 
> But then again I'm a perfectionist ;)

Not at all, you're perfectly right. I wasn't aware of these function, else I 
would have used them. I correct this right after this mail. When upgrading 
master to mob, do you simply merge mob in master or do you clean up things and 
squash commits ?
> 
> --- grischka
> 
Thomas Preud'homme

signature.asc
Description: This is a digitally signed message part.