[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Tinycc-devel] Re: [PATCH 7/7] tcc -E: Let output_default be <file>.o in
From: |
Kirill Smelkov |
Subject: |
[Tinycc-devel] Re: [PATCH 7/7] tcc -E: Let output_default be <file>.o instead of a.out |
Date: |
Sun, 20 Jun 2010 21:52:09 +0400 |
User-agent: |
Mutt/1.5.6i |
On Fri, Jun 18, 2010 at 09:24:28PM +0200, grischka wrote:
> Did you consider pushing the feature(s) on the tinycc mob branch?
Yes. And I though mob was a bit destabilized by "last member of union"
patches, so I decided not to continue that.
Yes, I've read tinycc.git intro text about mob, and it's really up to
you on how to pick patches. I just though posting by mail is also ok,
and as your comments show, having a look on them before inclusion allows
(hopefully) to merge them in a bit more good shape.
> Some suggestions:
>
> >+ /* compute default outfile name */
> >+ {
> >+ char *ext;
> >+
> Put that into a function.
Yes. I'm putting it into libtcc API as
LIBTCCAPI const char *tcc_default_target(TCCState *s)
> >+ /* dump collected dependencies */
> >+ if (gen_deps) {
> >+ ...
> Put that into a function.
Ok,
LIBTCCAPI void tcc_gen_makedeps(TCCState *s, const char *target, const char
*filename)
> >+ ext = strrchr(buf, '.');
> >+ ext = ext ? ext : strchr(buf, 0);
> Use tcc_fileextension().
Yes and thanks. I've though about tcc_fileextension(), but wrongly
decided that it's not for me because call to tcc_basename.
Thanks for suggestions - I'll repost reworked patches soon.
Kirill
[Tinycc-devel] [PATCH 5/7] tcc: Always compute default outfile name, Kirill Smelkov, 2010/06/16
[Tinycc-devel] [PATCH 3/7] chmod a-x i386-gen.c, Kirill Smelkov, 2010/06/16
[Tinycc-devel] [PATCH 1/7] .cvsignore -> .gitignore, Kirill Smelkov, 2010/06/16
[Tinycc-devel] [PATCH 6/7] tcc: Draft suppoprt for -MD/-MF options, Kirill Smelkov, 2010/06/16
[Tinycc-devel] [PATCH 4/7] tcc: Fix typo in error (it's '%s', not '%s), Kirill Smelkov, 2010/06/16