Re: [Tinycc-devel] Annoying new warning

[Michael Matz]

Hi,

On Sun, 7 May 2017, Christian Jullien wrote:

> Forget one moment what has been said so far and concentrate on my 
> concern with narrowed info.
>
> Facts:

Yes, all known and agreed upon.

> * Finally, arm-gen.c uses TOK___fixxfdi with yet another #if condition =>
> LDOUBLE_SIZE != 8
> #if LDOUBLE_SIZE != 8
>    else if(r2 == VT_LDOUBLE)
>      func=TOK___fixxfdi;
>    else if(r2 == VT_DOUBLE)
> #else
>
> So there is at least one combination of compiler/pre-processor options on
> ARM that may use __fixunsxfdi with a test on a uninitialized value.

LDOUBLE_SIZE != 8 is not possible in any arm config, so the function won't 
be actually used at runtime.  That's why your ifdef-ing out of these 
functions in libtcc1.c is fine, and it is what we suggested all along. 
(The dead code above should also be cleaned up to not cause further 
confusion).

But _read what I write_: you have also disabled some dfdi routines at the 
same time in your patch, not only the xfdi ones.  _That_ is the problem, 
you have ifdef-ed out other unrelated routines.


Ciao,
Michael.